Commit Graph

364 Commits

Author SHA1 Message Date
Pekka Enberg
698b87fc86 Merge pull request #133 from benclmnt/kqueue-io
Use kqueue for Darwin IO
2024-07-13 10:40:01 +03:00
Bennett Clement
30e4a70d07 ignore wasm compilation target 2024-07-13 15:17:18 +08:00
Pekka Enberg
9c8e94acee Merge pull request #132 from gvos94/graghura/add-pipfile 2024-07-13 06:52:55 +03:00
Bennett Clement
26152e07e5 Use kqueue for Darwin IO 2024-07-13 09:44:03 +08:00
gandeevanr
b728208526 Updated Pipfile 2024-07-12 13:07:34 -07:00
gandeevanr
31a8972d7f Updated README.md to use pipenv 2024-07-12 12:42:24 -07:00
gandeevanr
9466ec82e7 Added Pipfile and Pipfile.lock 2024-07-12 12:38:56 -07:00
Pekka Enberg
c419fa9385 Merge pull request #131 from seonWKim/fix-typos 2024-07-12 19:23:14 +03:00
김선우
6aabd919da Fix typo 2024-07-12 23:19:44 +09:00
Pekka Enberg
2540f7d127 Merge pull request #130 from JoanFM/feat-help-msg 2024-07-12 13:04:16 +03:00
Joan Martinez
346279f9bb add help message to CLI 2024-07-12 12:00:20 +02:00
Pekka Enberg
b14150f3b5 sqlite3: Add stubs to make Python build link
Add enough stubs to be able to link CPython build against Limbo's SQLite
compatibility API:

```
export LIBSQLITE3_LIBS=../limbo/target/debug/liblimbo_sqlite3.a
./configure
make -j8

[snip]

gcc -shared      Modules/_sqlite/blob.o Modules/_sqlite/connection.o Modules/_sqlite/cursor.o Modules/_sqlite/microprotocols.o Modules/_sqlite/module.o Modules/_sqlite/prepare_protocol.o Modules/_sqlite/row.o Modules/_sqlite/statement.o Modules/_sqlite/util.o ../limbo/target/debug/liblimbo_sqlite3.a  -o Modules/_sqlite3.cpython-314-x86_64-linux-gnu.so
thread '<unnamed>' panicked at sqlite3/src/lib.rs:751:5:
not yet implemented
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
make: *** [Makefile:1511: checksharedmods] Aborted (core dumped)
```

All that's left is to actually implement all of this...
2024-07-12 10:08:37 +03:00
Pekka Enberg
f6704ba3e0 Update opcode compat 2024-07-12 08:41:44 +03:00
Pekka Enberg
19d873f3e6 Update changelog and compat 2024-07-12 08:31:52 +03:00
Pekka Enberg
3e8da8e4c5 Document how to run compat tests with SQLite 2024-07-12 08:27:06 +03:00
Pekka Enberg
55adf93282 Fix broken WHERE clause test case
The broken test case does not pass on SQLite so it's wrong. I suspect
the test was written before commit e377e09 ("Fix avg(), total(), count()
default value on empty set") when Limbo showed this behavior.
2024-07-12 08:22:13 +03:00
Pekka Enberg
f1bca597cb Merge pull request #121 from jussisaurio/where-clauses
Basic where clause support
2024-07-12 08:21:38 +03:00
jussisaurio
1b0aa568a4 Basic where clause support 2024-07-12 00:26:32 +03:00
Pekka Enberg
3d15198d4c Update compatibility table and changelog 2024-07-11 20:13:16 +03:00
Pekka Enberg
4affff0655 Merge pull request #120 from benclmnt/fix-aggfn-empty-state
Fix avg(), total(), count() default value on empty set
2024-07-11 20:11:37 +03:00
Bennett Clement
e377e09498 Fix avg(), total(), count() default value on empty set 2024-07-12 00:20:44 +08:00
Pekka Enberg
79ba53f190 Merge pull request #119 from benclmnt/support-total-aggfn
Implement total() aggregation function
2024-07-11 18:48:16 +03:00
Bennett Clement
8a9eb74f9b Implement total() aggregation function
- Returns 0.0 when called on non integer / non float columns
- Always returns floating point number
- fix: default for sum() should be NULL when there is no non-NULL row
  per docs
2024-07-11 23:40:55 +08:00
Pekka Enberg
0a304a98b5 Merge pull request #117 from Ramkarthik/main 2024-07-11 14:23:04 +03:00
Ramkarthik Krishnamurthy
f038c1c7d2 Indent only the opcode value 2024-07-11 16:19:23 +05:30
Pekka Enberg
7f1cacf788 Update README.md 2024-07-11 11:09:54 +03:00
Pekka Enberg
d8af1aa73b Format source code with cargo fmt 2024-07-11 10:43:34 +03:00
Pekka Enberg
db73092592 Merge pull request #116 from penberg/limit-zero-cleanup
Simplify `LIMIT 0` handling in translate_select()
2024-07-11 09:58:35 +03:00
Pekka Enberg
d8078d5e19 Simplify LIMIT 0 handling in translate_select()
It's a special-case so let's make it special like SQLite does.
Simplifies the logic in `translate_select()` quite a bit.
2024-07-11 09:42:24 +03:00
Pekka Enberg
46e34daccd Merge pull request #115 from pereman2/real-affinity 2024-07-11 08:11:18 +03:00
Pere Diaz Bou
780908a771 cli: change float print
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-10 21:39:29 +02:00
Pere Diaz Bou
538d624770 core: apply Real affinity on columns stored as int
Values in sqlite3, as expected, can be stored in different formats to
optimize disk usage. In this case, a 79.0 float will be transformed to a
u8.

sqlite3 deals with this by adding a RealAffinity op after each column
that might need it. Therefore, in this pr we do exactly that :).

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-10 21:21:49 +02:00
Pekka Enberg
5e47dfabaf Drop Select::from member field
It's not used anywhere.
2024-07-10 15:17:04 +03:00
Pekka Enberg
a46912c355 Merge pull request #113 from penberg/kill-select-context
Fold SelectContext to Select
2024-07-10 15:13:37 +03:00
Pekka Enberg
0316385150 Fold SelectContext to Select
We can use Select to keep track of loops and stuff. Having a separate
SelectContext just means we need to pass around more objects to
functions.
2024-07-10 15:09:30 +03:00
Pekka Enberg
f2b1971def Simplify AST type paths
The `sqlite3_parser` prefix is redundant.
2024-07-10 11:08:07 +03:00
Pekka Enberg
5b36ca12ad Merge pull request #111 from Ramkarthik/main 2024-07-09 22:54:43 +03:00
Ramkarthik Krishnamurthy
ae68c96635 Indent EXPLAIN output like SQLite 2024-07-10 00:01:52 +05:30
Pekka Enberg
fee82542d4 Merge pull request #109 from pereman2/refactor-sqlite3WhereBegin 2024-07-09 20:16:33 +03:00
Pere Diaz Bou
e557b7b9ee core: add comment for src_tables
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:48:26 +02:00
Pere Diaz Bou
61d0f877e3 core: create list of src tables
Instead of having divided "from table" and "join tables", we merge them
in to a list of `src_tables`.

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:46:35 +02:00
Pere Diaz Bou
d41319a837 core: remove hash for Table
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:14:32 +02:00
Pere Diaz Bou
46592e7b34 core: fix translate_expr args from new agg functions
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:10:18 +02:00
Pere Diaz Bou
90a4fc6bb8 test: cross-join-specific-columns
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:08:16 +02:00
Pere Diaz Bou
110df3cff1 core: fix resolve table name from join
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:08:16 +02:00
Pere Diaz Bou
e0431fdde1 testing: update testing with products table and cross join test
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:08:16 +02:00
Pere Diaz Bou
0b0885325c core: refactor generation of table row read
In sqlite3 generating the loop to read multiple joined tables follows
the pattern:

```c
sqlite3WhereBegin();
sqlite3WhereEnd();
```

and this generates:
```
sqlite> explain select * from users, products;
addr  opcode         p1    p2    p3    p4             p5  comment
----  -------------  ----  ----  ----  -------------  --  -------------
0     Init           0     23    0                    0   Start at 23
1     OpenRead       0     2     0     10             0   root=2 iDb=0; users
2     OpenRead       1     3     0     3              0   root=3 iDb=0; products
3     Rewind         0     22    0                    0
4       Rewind         1     22    0                    0
5         Rowid          0     1     0                    0   r[1]=users.rowid
6         Column         0     1     2                    0   r[2]= cursor 0 column 1
7         Column         0     2     3                    0   r[3]= cursor 0 column 2
8         Column         0     3     4                    0   r[4]= cursor 0 column 3
9         Column         0     4     5                    0   r[5]= cursor 0 column 4
10        Column         0     5     6                    0   r[6]= cursor 0 column 5
11        Column         0     6     7                    0   r[7]= cursor 0 column 6
12        Column         0     7     8                    0   r[8]= cursor 0 column 7
13        Column         0     8     9                    0   r[9]= cursor 0 column 8
14        Column         0     9     10                   0   r[10]= cursor 0 column 9
15        Rowid          1     11    0                    0   r[11]=products.rowid
16        Column         1     1     12                   0   r[12]= cursor 1 column 1
17        Column         1     2     13                   0   r[13]= cursor 1 column 2
18        RealAffinity   13    0     0                    0
19        ResultRow      1     13    0                    0   output=r[1..13]
20      Next           1     5     0                    1
21    Next           0     4     0                    1
22    Halt           0     0     0                    0
23    Transaction    0     0     2     0              1   usesStmtJournal=0
24    Goto           0     1     0                    0
```

`sqlite3WhereBegin()` as the name represents, mainly does stuff with
`WHERE` expressions + loop generation. This is why I decided to change
the name to `translate_tables_begin` to try improve the naming.

In our case:
```rust
    translate_table_open_cursor(program, &mut context, select.from.as_ref().unwrap());
    translate_table_open_loop(program, &mut context, loop_index);
```

translates into:
```sql
> explain select * from users, products;
addr  opcode         p1    p2    p3    p4             p5  comment
----  -------------  ----  ----  ----  -------------  --  -------
0     Init           0     28    0       0   Start at 28
1     OpenReadAsync  0     2     0       0   root=2
2     OpenReadAwait  0     0     0       0
3     OpenReadAsync  1     3     0       0   root=3
4     OpenReadAwait  0     0     0       0
5     RewindAsync    0     0     0       0
6     RewindAwait    0     27    0       0
7     RewindAsync    1     0     0       0
8     RewindAwait    1     25    0       0
9     RowId          0     0     0       0
10    Column         0     1     1       0   r[1]= cursor 0 column 1
11    Column         0     2     2       0   r[2]= cursor 0 column 2
12    Column         0     3     3       0   r[3]= cursor 0 column 3
13    Column         0     4     4       0   r[4]= cursor 0 column 4
14    Column         0     5     5       0   r[5]= cursor 0 column 5
15    Column         0     6     6       0   r[6]= cursor 0 column 6
16    Column         0     7     7       0   r[7]= cursor 0 column 7
17    Column         0     8     8       0   r[8]= cursor 0 column 8
18    Column         0     9     9       0   r[9]= cursor 0 column 9
19    RowId          1     10    0       0
20    Column         1     1     11      0   r[11]= cursor 1 column 1
21    Column         1     2     12      0   r[12]= cursor 1 column 2
22    ResultRow      0     13    0       0   output=r[0..13]
23    NextAsync      1     0     0       0
24    NextAwait      1     8     0       0
25    NextAsync      0     0     0       0
26    NextAwait      0     6     0       0
27    Halt           0     0     0       0
28    Transaction    0     0     0       0
29    Goto           0     1     0       0
```

This works on as many joined tables but... it is ready to extend for
further join operations.

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-07-09 18:08:16 +02:00
Pekka Enberg
c5272afdd6 Add JSON functions to sqlite-compat.md 2024-07-09 12:28:31 +03:00
Pekka Enberg
704a9c214e Update compatibility doc and changelog 2024-07-09 12:17:55 +03:00
Pekka Enberg
01ed0f8257 Merge pull request #107 from ishanjain28/iouring_direct 2024-07-09 09:19:11 +03:00