aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-27 04:54:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #120 from benclmnt/fix-aggfn-empty-state

Browse Source 
Fix avg(), total(), count() default value on empty set
This commit is contained in:
Pekka Enberg
2024-07-11 20:11:37 +03:00
committed by GitHub
parent 79ba53f190 e377e09498
commit 4affff0655
1 changed files with 29 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
core/vdbe.rs
View File

@@ -594,23 +594,38 @@ impl Program {
state.pc += 1;
}
Insn::AggFinal { register, func } => {
match func {
AggFunc::Avg => {
let OwnedValue::Agg(agg) = state.registers[*register].borrow_mut()
else {
unreachable!();
match state.registers[*register].borrow_mut() {
OwnedValue::Agg(agg) => {
match func {
AggFunc::Avg => {
let AggContext::Avg(acc, count) = agg.borrow_mut() else {
unreachable!();
};
*acc /= count.clone();
}
AggFunc::Sum | AggFunc::Total => {}
AggFunc::Count => {}
AggFunc::Max => {}
AggFunc::Min => {}
_ => {
todo!();
}
};
let AggContext::Avg(acc, count) = agg.borrow_mut() else {
unreachable!();
};
*acc /= count.clone();
}
AggFunc::Sum | AggFunc::Total => {}
AggFunc::Count => {}
AggFunc::Max => {}
AggFunc::Min => {}
OwnedValue::Null => {
// when the set is empty
match func {
AggFunc::Total => {
state.registers[*register] = OwnedValue::Float(0.0);
}
AggFunc::Count => {
state.registers[*register] = OwnedValue::Integer(0);
}
_ => {}
}
}
_ => {
todo!();
unreachable!();
}
};
state.pc += 1;