Fail-fast camera mirroring on Android 11 and older

Co-authored-by: Romain Vimont <rom@rom1v.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>

app/scrcpy.1

@@ -458,6 +458,8 @@ The available encoders can be listed by \-\-list\-encoders.
 .BI "\-\-video\-source " source
 Select the video source (display or camera).
 
+Camera mirroring requires Android 12+.
+
 Default is display.
 
 .TP

app/src/cli.c

@@ -743,6 +743,7 @@ static const struct sc_option options[] = {
         .longopt = "video-source",
         .argdesc = "source",
         .text = "Select the video source (display or camera).\n"
+                "Camera mirroring requires Android 12+.\n"
                 "Default is display.",
     },
     {

server/src/main/java/com/genymobile/scrcpy/CameraAspectRatio.java

@@ -1,6 +1,6 @@
 package com.genymobile.scrcpy;
 
-public class CameraAspectRatio {
+public final class CameraAspectRatio {
     private static final float SENSOR = -1;
 
     private float ar;

server/src/main/java/com/genymobile/scrcpy/CameraCapture.java

@@ -135,8 +135,31 @@ public class CameraCapture extends SurfaceCapture {
             });
         }
 
-        Optional<android.util.Size> selected = stream.min(
-                Comparator.comparing(android.util.Size::getWidth).thenComparing(android.util.Size::getHeight).reversed());
+        Optional<android.util.Size> selected = stream.max((s1, s2) -> {
+            // Greater width is better
+            int cmp = Integer.compare(s1.getWidth(), s2.getWidth());
+            if (cmp != 0) {
+                return cmp;
+            }
+
+            if (targetAspectRatio != null) {
+                // Closer to the target aspect ratio is better
+                float ar1 = ((float) s1.getWidth() / s1.getHeight());
+                float arRatio1 = ar1 / targetAspectRatio;
+                float distance1 = Math.abs(1 - arRatio1);
+
+                float ar2 = ((float) s2.getWidth() / s2.getHeight());
+                float arRatio2 = ar2 / targetAspectRatio;
+                float distance2 = Math.abs(1 - arRatio2);
+
+                // Reverse the order because lower distance is better
+                return Float.compare(distance2, distance1);
+            }
+
+            // Greater height is better
+            return Integer.compare(s1.getHeight(), s2.getHeight());
+        });
+
         if (selected.isPresent()) {
             android.util.Size size = selected.get();
             return new Size(size.getWidth(), size.getHeight());
@@ -206,13 +229,11 @@ public class CameraCapture extends SurfaceCapture {
     @SuppressLint("MissingPermission")
     @TargetApi(Build.VERSION_CODES.S)
     private CameraDevice openCamera(String id) throws CameraAccessException, InterruptedException {
-        Ln.v("Open Camera: " + id);
-
         CompletableFuture<CameraDevice> future = new CompletableFuture<>();
         ServiceManager.getCameraManager().openCamera(id, new CameraDevice.StateCallback() {
             @Override
             public void onOpened(CameraDevice camera) {
-                Ln.v("Open Camera Success");
+                Ln.d("Camera opened successfully");
                 future.complete(camera);
             }
 
@@ -255,17 +276,13 @@ public class CameraCapture extends SurfaceCapture {
 
     @TargetApi(Build.VERSION_CODES.S)
     private CameraCaptureSession createCaptureSession(CameraDevice camera, Surface surface) throws CameraAccessException, InterruptedException {
-        Ln.d("Create Capture Session");
-
         CompletableFuture<CameraCaptureSession> future = new CompletableFuture<>();
-        // replace by createCaptureSession(SessionConfiguration)
         OutputConfiguration outputConfig = new OutputConfiguration(surface);
         List<OutputConfiguration> outputs = Arrays.asList(outputConfig);
         SessionConfiguration sessionConfig = new SessionConfiguration(SessionConfiguration.SESSION_REGULAR, outputs, cameraExecutor,
                 new CameraCaptureSession.StateCallback() {
                     @Override
                     public void onConfigured(CameraCaptureSession session) {
-                        Ln.d("Create Capture Session Success");
                         future.complete(session);
                     }
 
@@ -310,4 +327,4 @@ public class CameraCapture extends SurfaceCapture {
     public boolean isClosed() {
         return disconnected.get();
     }
-}
+}

server/src/main/java/com/genymobile/scrcpy/Server.java

@@ -2,7 +2,6 @@ package com.genymobile.scrcpy;
 
 import android.os.BatteryManager;
 import android.os.Build;
-import android.os.Looper;
 
 import java.io.IOException;
 import java.util.ArrayList;
@@ -89,6 +88,12 @@ public final class Server {
 
     private static void scrcpy(Options options) throws IOException, ConfigurationException {
         Ln.i("Device: [" + Build.MANUFACTURER + "] " + Build.BRAND + " " + Build.MODEL + " (Android " + Build.VERSION.RELEASE + ")");
+
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.S && options.getVideoSource() == VideoSource.CAMERA) {
+            Ln.e("Camera mirroring is not supported before Android 12");
+            throw new ConfigurationException("Camera mirroring is not supported");
+        }
+
         final Device device = new Device(options);
 
         Thread initThread = startInitThread(options);

server/src/main/java/com/genymobile/scrcpy/VideoSource.java

@@ -1,7 +1,5 @@
 package com.genymobile.scrcpy;
 
-import android.media.MediaRecorder;
-
 public enum VideoSource {
     DISPLAY("display"),
     CAMERA("camera");

server/src/main/java/com/genymobile/scrcpy/Workarounds.java

@@ -32,7 +32,7 @@ public final class Workarounds {
         Workarounds.prepareMainLooper();
 
         boolean mustFillAppInfo = false;
-        boolean mustFillBaseContext = true;
+        boolean mustFillBaseContext = false;
         boolean mustFillAppContext = false;
 
         if (Build.BRAND.equalsIgnoreCase("meizu")) {
@@ -66,6 +66,7 @@ public final class Workarounds {
 
         if (camera) {
             mustFillAppInfo = true;
+            mustFillBaseContext = true;
         }
 
         if (mustFillAppInfo) {

server/src/main/java/com/genymobile/scrcpy/wrappers/ServiceManager.java

@@ -1,7 +1,6 @@
 package com.genymobile.scrcpy.wrappers;
 
 import com.genymobile.scrcpy.FakeContext;
-import com.genymobile.scrcpy.Workarounds;
 
 import android.annotation.SuppressLint;
 import android.content.Context;