aljaz/scrcpy
1
0
Fork 0
mirror of https://github.com/Genymobile/scrcpy.git synced 2026-02-21 22:04:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix segfault on rotation while recording

Browse Source 
The packet sink push_session() callback is optional, but it was called
unconditionnally even when not implemented, leading to a segfault.

Bug introduced by commit 78cba1b7c2.

Fixes #6687 <https://github.com/Genymobile/scrcpy/issues/6687>
This commit is contained in:
Romain Vimont
2026-02-21 10:45:12 +01:00
parent 23710e04c1
commit f91fa56593
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/trait/packet_source.c
View File

@@ -67,7 +67,8 @@ sc_packet_source_sinks_push_session(struct sc_packet_source *source,
assert(source->sink_count);
for (unsigned i = 0; i < source->sink_count; ++i) {
struct sc_packet_sink *sink = source->sinks[i];
if (!sink->ops->push_session(sink, session)) {
if (sink->ops->push_session
&& !sink->ops->push_session(sink, session)) {
return false;
}
}