From f91fa56593ecf1b6b5355b000899fbcc465e845b Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Sat, 21 Feb 2026 10:45:12 +0100 Subject: [PATCH] Fix segfault on rotation while recording The packet sink push_session() callback is optional, but it was called unconditionnally even when not implemented, leading to a segfault. Bug introduced by commit 78cba1b7c29fe45057d180a183ce7efcd7044106. Fixes #6687 --- app/src/trait/packet_source.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/trait/packet_source.c b/app/src/trait/packet_source.c index 49cb6d14..55429b61 100644 --- a/app/src/trait/packet_source.c +++ b/app/src/trait/packet_source.c @@ -67,7 +67,8 @@ sc_packet_source_sinks_push_session(struct sc_packet_source *source, assert(source->sink_count); for (unsigned i = 0; i < source->sink_count; ++i) { struct sc_packet_sink *sink = source->sinks[i]; - if (!sink->ops->push_session(sink, session)) { + if (sink->ops->push_session + && !sink->ops->push_session(sink, session)) { return false; } }