Commit Graph

821 Commits

Author SHA1 Message Date
Rajiv Harlalka
0b5b0a426d remove redundant comment
Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
2024-08-30 20:28:37 +05:30
Rajiv Harlalka
e2013b0ef6 add unixepoch tests
Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
2024-08-30 20:28:35 +05:30
Rajiv Harlalka
1de974253b add support for custom date time value as first parameter
Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
2024-08-30 20:27:59 +05:30
Rajiv Harlalka
6684fb46e4 FEAT: Implement the unixepoch function
Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
2024-08-30 20:27:58 +05:30
Pekka Enberg
1aa7a7c52c Merge 'ci: added python' from Jean Arhancet
Added a GitHub CI action for the Python bindings with Maturin for
building, Ruff for formatting checks, and pytest for running tests. This
is related to #248

Closes #298
2024-08-30 17:34:43 +03:00
Pekka Enberg
63c91b83ed Merge 'Add time querying to I/O trait for deterministic simulation' from mason
Follow-up PR to this [issue](https://github.com/penberg/limbo/issues/272).

Closes #307
2024-08-30 17:33:23 +03:00
JeanArhancet
fc2962e04e ci: integrate pyo3
ci: add manylinux

fix: maturin build error

ci: add wheels upload

ci: use venv
2024-08-25 21:47:17 +02:00
mazchew
671b61ba19 add time querying to io trait 2024-08-25 22:55:15 +08:00
Pekka Enberg
93964c6655 Merge 'core: simplify page buffer handling' from Pere Diaz Bou
Closes #308
2024-08-25 14:31:42 +03:00
Pere Díaz
19f000238c core: simplify page buffer handling 2024-08-25 12:48:37 +02:00
Pekka Enberg
596abed93b Merge 'core: support modifiers in time function' from Sonny
this PR is a continue of #252 and #277 to resolve #158.

- supports modifiers in `time(..)` functions

```
limbo> select time('now');
11:35:22

limbo> select time('now', '+2 hours', '-3 hours');
10:35:02

limbo> explain select time('now', '+2 hours', '-3 hours');
addr  opcode             p1    p2    p3    p4             p5  comment
----  -----------------  ----  ----  ----  -------------  --  -------
0     Init               0     7     0                    0   Start at 7
1     String8            0     2     0     now            0   r[2]='now'
2     String8            0     3     0     +2 hours       0   r[3]='+2 hours'
3     String8            0     4     0     -3 hours       0   r[4]='-3 hours'
4     Function           1     2     1     time           0   r[1]=func(r[2..])
5     ResultRow          1     1     0                    0   output=r[1]
6     Halt               0     0     0                    0
7     Transaction        0     0     0                    0
8     Goto               0     1     0                    0

```

Closes #305
2024-08-25 13:24:43 +03:00
Pekka Enberg
5da38aa11d Merge 'core: fix concat function wrong start_register' from Sonny
## What does PR do?
- fix concat function wrong start_register

## Current behavior
- addr 4 `r[1]=func(r[1..])`
- `r[1]` is target register to store the result, should not be the start reg of the function arguments
- it should be `r[1]=func(r[2..])` where
  - `r[2]` is the start of arguments
  - `r[1]` is target register to store the result

```
limbo> explain SELECT concat('SQLite',' ','Concat') result;
addr  opcode             p1    p2    p3    p4             p5  comment
----  -----------------  ----  ----  ----  -------------  --  -------
0     Init               0     7     0                    0   Start at 7
1     String8            0     2     0     SQLite         0   r[2]='SQLite'
2     String8            0     3     0                    0   r[3]=' '
3     String8            0     4     0     Concat         0   r[4]='Concat'
4     Function           1     1     1     concat         0   r[1]=func(r[1..])
5     ResultRow          1     1     0                    0   output=r[1]
6     Halt               0     0     0                    0
7     Transaction        0     0     0                    0
8     Goto               0     1     0                    0
```

## Expected behavior after the fix
- `r[1]=func(r[2..])` where `r[2]` is the start of arguments

```
limbo> explain SELECT concat('SQLite',' ','Concat') result;

addr  opcode             p1    p2    p3    p4             p5  comment
----  -----------------  ----  ----  ----  -------------  --  -------
0     Init               0     7     0                    0   Start at 7
1     String8            0     2     0     SQLite         0   r[2]='SQLite'
2     String8            0     3     0                    0   r[3]=' '
3     String8            0     4     0     Concat         0   r[4]='Concat'
4     Function           1     2     1     concat         0   r[1]=func(r[2..])
5     ResultRow          1     1     0                    0   output=r[1]
6     Halt               0     0     0                    0
7     Transaction        0     0     0                    0
8     Goto               0     1     0                    0
```

Closes #304
2024-08-25 13:24:22 +03:00
Pekka Enberg
053ba5e126 Merge 'Don't do any I/O if top level operator is Nothing' from Jussi Saurio
Small tweak

Before:

```
limbo> explain select * from users where 0;
addr  opcode             p1    p2    p3    p4             p5  comment
----  -----------------  ----  ----  ----  -------------  --  -------
0     Init               0     21    0                    0   Start at 21
1     OpenReadAsync      0     2     0                    0   table=users, root=2
2     OpenReadAwait      0     0     0                    0
3     RewindAsync        0     0     0                    0
4     RewindAwait        0     20    0                    0   Rewind table users
5       Integer          0     1     0                    0   r[1]=0
6       IfNot            1     18    1                    0   if !r[1] goto 18
7       RowId            0     2     0                    0   r[2]=users.rowid
8       Column           0     1     3                    0   r[3]=users.first_name
9       Column           0     2     4                    0   r[4]=users.last_name
10      Column           0     3     5                    0   r[5]=users.email
11      Column           0     4     6                    0   r[6]=users.phone_number
12      Column           0     5     7                    0   r[7]=users.address
13      Column           0     6     8                    0   r[8]=users.city
14      Column           0     7     9                    0   r[9]=users.state
15      Column           0     8     10                   0   r[10]=users.zipcode
16      Column           0     9     11                   0   r[11]=users.age
17      ResultRow        2     10    0                    0   output=r[2..11]
18    NextAsync          0     0     0                    0
19    NextAwait          0     4     0                    0
20    Halt               0     0     0                    0
21    Transaction        0     0     0                    0
22    Goto               0     1     0                    0
```

After:

```
limbo> explain select * from users where 0;
addr  opcode             p1    p2    p3    p4             p5  comment
----  -----------------  ----  ----  ----  -------------  --  -------
0     Init               0     2     0                    0   Start at 2
1     Halt               0     0     0                    0
2     Transaction        0     0     0                    0
3     Goto               0     1     0                    0
```

Closes #306
2024-08-25 13:23:20 +03:00
jussisaurio
d1059da9f1 Return enum instead of bool for better documentation 2024-08-25 11:15:47 +03:00
jussisaurio
d653f550e2 Don't do any I/O if top level operator is Nothing 2024-08-25 10:43:52 +03:00
sonhmai
c32bb91dd5 core: support modifiers in time function 2024-08-24 18:31:34 +07:00
sonhmai
9af811233b core: fix concat function wrong start_register 2024-08-24 16:14:28 +07:00
Pekka Enberg
84ed081f19 Merge 'Added random number generation to I/O trait for simulation' from mason
Took a stab at the RNG portion of this [issue](https://github.com/penberg/limbo/issues/272), do let me know if there's anything that I can improve on/rework!

Thanks!

Closes #301
2024-08-22 18:43:01 +03:00
mazchew
156005694a added rng to io trait for simulation 2024-08-22 23:24:02 +08:00
Pekka Enberg
d11dd9d06c cargo dist: Disable static library installation
Looks to be broke on Windows:

https://github.com/axodotdev/cargo-dist/issues/1356
2024-08-22 18:06:36 +03:00
Pekka Enberg
6e8a1117fe sqlite3: Format source code with cargo fmt 2024-08-22 17:54:25 +03:00
Pekka Enberg
c69b2ab4f6 sqlite3: Fix LFS feature flag 2024-08-22 17:53:07 +03:00
Pekka Enberg
b1f508db87 Limbo 0.0.4 2024-08-22 17:44:28 +03:00
Pekka Enberg
51eebb8ea5 Merge 'Add support for nullif scalar function' from Kim Seon Woo
### EXPLAIN nullif(1,2)
<img width="1339" alt="image" src="https://github.com/user-attachments/assets/08230797-914d-4922-b52c-5b2b2b4c2a12">

### Issue
https://github.com/penberg/limbo/issues/144

Closes #299
2024-08-20 20:47:35 +03:00
Kim Seon Woo
8f617dd394 Apply fmt 2024-08-20 18:44:06 +02:00
Kim Seon Woo
8bb2a48cb6 Add support for nullif scalar function 2024-08-20 18:36:06 +02:00
Pekka Enberg
87ff71152a Merge 'Fix INSERT to empty tables panic' from Kim Seon Woo
`page` from `let page = page.borrow()` lives while `write_complete` is running.

Ensure that `page` is dropped

https://github.com/penberg/limbo/issues/257

Closes #293
2024-08-19 07:35:26 +03:00
Kim Seon Woo
9d878fda55 Remove failing test for now 2024-08-18 21:05:01 +02:00
Kim Seon Woo
a95fcc0fc1 Fix test to check whether error message is included 2024-08-18 21:00:37 +02:00
Kim Seon Woo
98f32b6182 Remove database.db 2024-08-18 21:00:37 +02:00
Kim Seon Woo
c6402aa341 Add tcl 2024-08-18 21:00:36 +02:00
Kim Seon Woo
78817d3804 Fix insert error 2024-08-18 21:00:03 +02:00
Kim Seon Woo
f406481849 Explain why it fails 2024-08-18 21:00:03 +02:00
Pekka Enberg
9404a561a9 Merge 'core: pretty-print EXPLAIN QUERY PLAN' from Piotr Sarna
Mimics SQLite's EXPLAIN QUERY PLAN pretty printer.

Example run on a preexisting db:
```
$ cargo run /tmp/srn "explain query plan select * from t natural join t join t2 on t.id = 2*t2.id where t.id in (select * from t);"
QUERY PLAN
`--JOIN ON t.id = 2 * t2.id
   |--JOIN
   |  |--SCAN t FILTER t.id IN (SELECT * FROM t)
   |  `--SCAN t
   `--SCAN t2

```

Fixes https://github.com/penberg/limbo/issues/295

Closes #296
2024-08-18 21:34:16 +03:00
Piotr Sarna
d8002ff03c core: pretty-print EXPLAIN QUERY PLAN
Mimics SQLite's EXPLAIN QUERY PLAN pretty printer.

Example run on a preexisting db:
```
$ cargo run /tmp/srn "explain query plan select * from t natural join t join t2 on t.id = 2*t2.id where t.id in (select * from t);"
QUERY PLAN
`--JOIN ON t.id = 2 * t2.id
   |--JOIN
   |  |--SCAN t FILTER t.id IN (SELECT * FROM t)
   |  `--SCAN t
   `--SCAN t2

```

Fixes https://github.com/penberg/limbo/issues/295
2024-08-18 20:11:19 +02:00
Pekka Enberg
ef30fe27d3 Update CHANGELOG 2024-08-18 16:37:06 +03:00
Pekka Enberg
edf0f754f6 Merge 'More structured query planner' from Jussi Saurio
Reader's guide to this PR:

The aim is to have a more structured and maintainable approach to generating bytecode from the query AST so that different parts of the query processing pipeline have clearer responsibilities, so that developing new functionality is easier. E.g.:

- If you want to implement join reordering -> you do it in `Optimizer`
- If you want to implement `GROUP BY` -> you change `QueryPlanNode::Aggregate` to include it, parse it in `Planner` and handle the code generation for it in `Emitter`

The pipeline is:

`SQL text -> Parser -> Planner -> Optimizer -> Emitter`

and this pipeline generates:

`SQL text -> AST -> Logical Plan -> Optimized Logical Plan -> SQLite Bytecode`

---

Module structure:

`plan.rs`: defines the `Operator` enum. An `Operator` is a tree of other `Operators`, e.g. an `Operator::Join` has `left` and `right` children, etc.

`planner.rs`: Parses an `ast::Select` into a `Plan` which is mainly a wrapper for a root `Operator`

`optimizer.rs`: Makes a new `Plan` from an input `Plan` - does predicate pushdown, constant elimination and turns `Scan` nodes into `SeekRowId` nodes where applicable

`emitter.rs`: Generates bytecode instructions from an input `Plan`.

---

Adds feature `EXPLAIN QUERY PLAN <stmt>` which shows the logical query plan instead of the bytecode plan

---

Other changes:

- Almost everything from `select.rs` removed; things like `translate_aggregation()` moved to `expr.rs`
- `where_clause.rs` removed, some things from it like `translate_condition_expr()` moved to `expr.rs`
- i.e.: there is nothing _new_ in `expr.rs`, stuff just moved there

---

Concerns:

- Perf impact: there's a lot more indirection than before (`Operator`s are very "traditional" trees where they refer to other operators via Boxes etc)

Closes #281
2024-08-18 16:36:51 +03:00
Pekka Enberg
68357ccb55 Update CHANGELOG 2024-08-18 15:53:24 +03:00
Pekka Enberg
9654840e64 Merge 'Add support for quote scalar function' from Jean Arhancet
Add support for quote scalar function. Related issue: #144

Closes #294
2024-08-18 15:53:09 +03:00
jussisaurio
a79c0c5b34 BytecodeGenerator struct was unnecessary 2024-08-17 14:35:44 +03:00
jussisaurio
2b71a5802d tweak 2024-08-17 14:24:20 +03:00
jussisaurio
b7fbe57ca7 Move translate_table_columns to expr.rs 2024-08-17 14:16:56 +03:00
jussisaurio
05a6616803 BytecodeGenerator struct 2024-08-17 14:12:57 +03:00
jussisaurio
d7d195a618 Cleanup and improve emitter.rs docs 2024-08-17 13:56:59 +03:00
jussisaurio
e8c894e532 More flexible Emitter via stateful operators 2024-08-17 12:55:16 +03:00
JeanArhancet
b6c720c90a feat: add quote function 2024-08-17 09:28:14 +02:00
jussisaurio
d70eb6b3d7 fix seekrowid operator not emitting result when root 2024-08-17 09:16:24 +03:00
jussisaurio
69f549d2b9 remove unnecessary unwrap_or 2024-08-17 09:07:29 +03:00
jussisaurio
2e7f240bb5 use table_columns() for seekrowid result_columns() 2024-08-17 09:04:27 +03:00
jussisaurio
25033d280c more accurate variable name 2024-08-16 19:58:59 +03:00