aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-01-03 08:24:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'Fix tx isolation test semantics after #3023' from Jussi Saurio

Browse Source 
After the fix in #3023, the transaction isolation fuzz test now
incorrectly takes a shadow snapshot of the DB state too early - before
it is determined that the connection successfully started a read
transaction.
Fix: take the snapshot after we've verified that the read TX started.
Closes #3025

Closes #3026
This commit is contained in:
Pekka Enberg
2025-09-11 18:21:00 +03:00
committed by GitHub
parent aeb3c217e1 6a7bead482
commit ebd9da4369
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/integration/fuzz_transaction/mod.rs
View File

@@ -731,10 +731,6 @@ async fn multiple_connections_fuzz(mvcc_enabled: bool) {
let columns = stmt.columns();
let mut rows = stmt.query(()).await.unwrap();
if let Some(tx_id) = *current_tx_id {
shared_shadow_db.take_snapshot_if_not_exists(tx_id);
}
let mut real_rows = Vec::new();
let ok = loop {
match rows.next().await {
@@ -766,6 +762,10 @@ async fn multiple_connections_fuzz(mvcc_enabled: bool) {
continue;
}
if let Some(tx_id) = *current_tx_id {
shared_shadow_db.take_snapshot_if_not_exists(tx_id);
}
real_rows.sort_by_key(|r| r.id);
let mut expected_rows = visible_rows.clone();