aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-27 13:04:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'make sure our responses are compliant with MCP' from Glauber Costa

Browse Source 
There is an inconsistency now on how we are handling IDs and
notifications. Claude Code doesn't complain (good boi), but Claude
Desktop does.

Closes #2649
This commit is contained in:
Pekka Enberg
2025-08-18 19:21:50 +03:00
committed by GitHub
parent 2b7355d126 40efaab382
commit e6804feb52
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
cli/mcp_server.rs
View File

@@ -116,9 +116,12 @@ impl TursoMcpServer {
};
let response = self.handle_request(request);
let response_json = serde_json::to_string(&response)?;
writeln!(stdout_lock, "{response_json}")?;
stdout_lock.flush()?;
// Don't send a response for notifications (when id is None)
if response.id.is_some() || response.error.is_some() {
let response_json = serde_json::to_string(&response)?;
writeln!(stdout_lock, "{response_json}")?;
stdout_lock.flush()?;
}
}
Ok(Err(_)) => {
// Error reading from stdin
@@ -139,6 +142,18 @@ impl TursoMcpServer {
}
fn handle_request(&self, request: JsonRpcRequest) -> JsonRpcResponse {
// Check if this is a notification (no id field means it's a notification)
// Notifications should not receive a response according to JSON-RPC spec
if request.id.is_none() {
// For notifications, we return a special response that the caller should ignore
return JsonRpcResponse {
jsonrpc: "2.0".to_string(),
id: None,
result: None,
error: None,
};
}
match request.method.as_str() {
"initialize" => self.handle_initialize(request),
"tools/list" => self.handle_list_tools(request),