aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-01-18 15:44:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'parser: translate boolean values to literal when parsing column constraints' from Preston Thorpe

Browse Source 
closes #3796

Closes #3804
This commit is contained in:
Pekka Enberg
2025-10-22 09:11:03 +03:00
committed by GitHub
parent 1aad1b224a 2f401c0bcc
commit d45a8da2f2
2 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
parser/src/parser.rs
View File

@@ -3120,9 +3120,17 @@ impl<'a> Parser<'a> {
TK_NULL | TK_BLOB | TK_STRING | TK_FLOAT | TK_INTEGER | TK_CTIME_KW => {
Ok(ColumnConstraint::Default(self.parse_term()?))
}
_ => Ok(ColumnConstraint::Default(Box::new(Expr::Id(
self.parse_nm()?,
)))),
_ => {
let name = self.parse_nm()?;
let expr = if name.as_str().eq_ignore_ascii_case("true") {
Expr::Literal(Literal::Numeric("1".into()))
} else if name.as_str().eq_ignore_ascii_case("false") {
Expr::Literal(Literal::Numeric("0".into()))
} else {
Expr::Id(name)
};
Ok(ColumnConstraint::Default(Box::new(expr)))
}
}
}

14
testing/create_table.test
View File

@@ -101,3 +101,17 @@ do_execsql_test_in_memory_any_error create_view_index_collision-1 {
CREATE INDEX ix_same ON t4(w);
CREATE VIEW ix_same AS SELECT 1;
}
# https://github.com/tursodatabase/turso/issues/3796
do_execsql_test_on_specific_db {:memory:} col-default-true {
create table t(id integer primary key, a default true);
insert into t (id) values (1);
SELECT a from t;
} {1}
# https://github.com/tursodatabase/turso/issues/3796
do_execsql_test_on_specific_db {:memory:} col-default-false {
create table t(id integer primary key, a default false);
insert into t (id) values (1);
SELECT a from t;
} {0}