aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-09 18:24:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Handle freeing memory in finalize, remove unused free fn

Browse Source
This commit is contained in:
PThorpe92
2025-01-17 21:54:25 -05:00
parent fc82461eff
commit b57308003e
2 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/core/src/lib.rs
View File

@@ -43,7 +43,6 @@ pub trait Scalar {
#[repr(C)]
pub struct AggCtx {
pub state: *mut c_void,
pub free: Option<extern "C" fn(*mut c_void)>,
}
pub trait AggFunc {

11
macros/src/lib.rs
View File

@@ -211,7 +211,6 @@ pub fn derive_agg_func(input: TokenStream) -> TokenStream {
let step_fn_name = format_ident!("{}_step", struct_name);
let finalize_fn_name = format_ident!("{}_finalize", struct_name);
let init_fn_name = format_ident!("{}_init", struct_name);
let free_fn_name = format_ident!("{}_free", struct_name);
let register_fn_name = format_ident!("register_{}", struct_name);
let expanded = quote! {
@@ -221,20 +220,10 @@ pub fn derive_agg_func(input: TokenStream) -> TokenStream {
let state = Box::new(<#struct_name as ::limbo_ext::AggFunc>::State::default());
let ctx = Box::new(::limbo_ext::AggCtx {
state: Box::into_raw(state) as *mut ::std::os::raw::c_void,
free: Some(#struct_name::#free_fn_name),
});
Box::into_raw(ctx)
}
#[no_mangle]
pub extern "C" fn #free_fn_name(state: *mut ::std::os::raw::c_void) {
if !state.is_null() {
unsafe {
let _ = Box::from_raw(state as *mut <#struct_name as ::limbo_ext::AggFunc>::State);
}
}
}
#[no_mangle]
pub extern "C" fn #step_fn_name(
ctx: *mut ::limbo_ext::AggCtx,