aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-23 08:55:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove assertions from Completion::complete() and Completion::error()

Browse Source 
The completion callback can be invoked only once via `OnceLock`, let's not
crash if we e.g. call `Completion::abort()` on an already finished completion.

Closes #2673
This commit is contained in:
Jussi Saurio
2025-08-19 21:53:42 +03:00
parent a82930d641
commit b5439dd068
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/io/mod.rs
View File

@@ -1,6 +1,6 @@
use crate::storage::buffer_pool::ArenaBuffer;
use crate::storage::sqlite3_ondisk::WAL_FRAME_HEADER_SIZE;
use crate::{turso_assert, BufferPool, CompletionError, Result};
use crate::{BufferPool, CompletionError, Result};
use bitflags::bitflags;
use cfg_block::cfg_block;
use std::cell::RefCell;
@@ -217,10 +217,6 @@ impl Completion {
}
pub fn complete(&self, result: i32) {
turso_assert!(
!self.finished(),
"should not complete a finished Completion"
);
if self.inner.result.set(None).is_ok() {
let result = Ok(result);
match &self.inner.completion_type {
@@ -233,7 +229,6 @@ impl Completion {
}
pub fn error(&self, err: CompletionError) {
turso_assert!(!self.finished(), "should not error a finished Completion");
if self.inner.result.set(Some(err)).is_ok() {
let result = Err(err);
match &self.inner.completion_type {