aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-01-05 01:04:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'core/schema: get_dependent_materialized_views_unnormalized' from Pere Diaz Bou

Browse Source 
If we get a table name for in memory structure, it's safe to assume it's
already normalized.

Closes #2830
This commit is contained in:
Pekka Enberg
2025-08-28 14:34:06 +03:00
committed by GitHub
parent eba90e1c5e 48e5ad7a55
commit a5322d2ab7
2 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/schema.rs
View File

@@ -157,6 +157,15 @@ impl Schema {
.unwrap_or_default()
}
/// Get all materialized views that depend on a given table, skip normalizing ident.
/// We are basically assuming we already normalized the ident.
pub fn get_dependent_materialized_views_unnormalized(
&self,
table_name: &str,
) -> Option<&Vec<String>> {
self.table_to_materialized_views.get(table_name)
}
/// Populate all materialized views by scanning their source tables
/// Returns IOResult to support async execution
pub fn populate_materialized_views(

21
core/vdbe/execute.rs
View File

@@ -5177,11 +5177,12 @@ pub fn op_insert(
match &state.op_insert_state.sub_state {
OpInsertSubState::MaybeCaptureRecord => {
let schema = program.connection.schema.borrow();
let dependent_views = schema.get_dependent_materialized_views(table_name);
let dependent_views =
schema.get_dependent_materialized_views_unnormalized(table_name);
// If there are no dependent views, we don't need to capture the old record.
// We also don't need to do it if the rowid of the UPDATEd row was changed, because that means
// we deleted it earlier and `op_delete` already captured the change.
if dependent_views.is_empty() || flag.has(InsertFlags::UPDATE_ROWID_CHANGE) {
if dependent_views.is_none() || flag.has(InsertFlags::UPDATE_ROWID_CHANGE) {
if flag.has(InsertFlags::REQUIRE_SEEK) {
state.op_insert_state.sub_state = OpInsertSubState::Seek;
} else {
@@ -5287,8 +5288,9 @@ pub fn op_insert(
state.op_insert_state.sub_state = OpInsertSubState::UpdateLastRowid;
} else {
let schema = program.connection.schema.borrow();
let dependent_views = schema.get_dependent_materialized_views(table_name);
if !dependent_views.is_empty() {
let dependent_views =
schema.get_dependent_materialized_views_unnormalized(table_name);
if dependent_views.is_some() {
state.op_insert_state.sub_state = OpInsertSubState::ApplyViewChange;
} else {
break;
@@ -5308,8 +5310,9 @@ pub fn op_insert(
program.n_change.set(prev_changes + 1);
}
let schema = program.connection.schema.borrow();
let dependent_views = schema.get_dependent_materialized_views(table_name);
if !dependent_views.is_empty() {
let dependent_views =
schema.get_dependent_materialized_views_unnormalized(table_name);
if dependent_views.is_some() {
state.op_insert_state.sub_state = OpInsertSubState::ApplyViewChange;
continue;
}
@@ -5317,8 +5320,10 @@ pub fn op_insert(
}
OpInsertSubState::ApplyViewChange => {
let schema = program.connection.schema.borrow();
let dependent_views = schema.get_dependent_materialized_views(table_name);
assert!(!dependent_views.is_empty());
let dependent_views =
schema.get_dependent_materialized_views_unnormalized(table_name);
assert!(dependent_views.is_some());
let dependent_views = dependent_views.unwrap();
let (key, values) = {
let mut cursor = state.get_cursor(*cursor_id);