aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-25 12:04:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

translate/insert: string fmt perf improvmenets

Browse Source
This commit is contained in:
Pere Diaz Bou
2025-08-27 17:18:57 +00:00
parent b4eba8b456
commit 964422375e
1 changed files with 29 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
core/translate/insert.rs
View File

@@ -114,7 +114,7 @@ pub fn translate_insert(
Expr::Id(name) => {
if name.is_double_quoted() {
*expr =
Expr::Literal(ast::Literal::String(format!("{name}"))).into();
Expr::Literal(ast::Literal::String(name.to_string())).into();
} else {
// an INSERT INTO ... VALUES (...) cannot reference columns
crate::bail_parse_error!("no such column: {name}");
@@ -375,9 +375,14 @@ pub fn translate_insert(
target_pc: make_record_label,
});
let rowid_column_name = insertion.key.column_name();
let mut description =
String::with_capacity(table_name.as_str().len() + rowid_column_name.len() + 2);
description.push_str(table_name.as_str());
description.push('.');
description.push_str(rowid_column_name);
program.emit_insn(Insn::Halt {
err_code: SQLITE_CONSTRAINT_PRIMARYKEY,
description: format!("{}.{}", table_name.as_str(), rowid_column_name),
description,
});
program.preassign_label_to_next_insn(make_record_label);
}
@@ -486,15 +491,28 @@ pub fn translate_insert(
program.emit_insn(Insn::HaltIfNull {
target_reg: column_mapping.register,
err_code: SQLITE_CONSTRAINT_NOTNULL,
description: format!(
"{}.{}",
table_name,
column_mapping
.column
.name
.as_ref()
.expect("Column name must be present")
),
description: {
let mut description = String::with_capacity(
table_name.as_str().len()
+ column_mapping
.column
.name
.as_ref()
.expect("Column name must be present")
.len()
+ 2,
);
description.push_str(table_name.as_str());
description.push('.');
description.push_str(
column_mapping
.column
.name
.as_ref()
.expect("Column name must be present"),
);
description
},
});
}
// Create and insert the record