aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-30 06:24:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix stupid comment

Browse Source
This commit is contained in:
jussisaurio
2024-11-26 18:37:06 +02:00
parent 1b34698872
commit 7d569aee1f
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/translate/emitter.rs
View File

@@ -1713,14 +1713,12 @@ fn order_by_sorter_insert(
);
Ok(())
}
/// We need to handle the case where we are emitting to sorter.
/// In that case the first columns should be the sort key columns, and the rest is the result columns of the select.
/// In case any of the sort keys are exactly equal to a result column, we can skip emitting that result column.
/// We need to do this before rewriting the result columns to registers because we need to know which columns to skip.
/// Moreover, we need to keep track what index in the ORDER BY sorter the result columns have, because the result columns
/// should be emitted in the SELECT clause order, not the ORDER BY clause order.
/// In case any of the ORDER BY sort keys are exactly equal to a result column, we can skip emitting that result column.
/// If we skip a result column, we need to keep track what index in the ORDER BY sorter the result columns have,
/// because the result columns should be emitted in the SELECT clause order, not the ORDER BY clause order.
///
/// If any result columsn can be skipped, returns list of 2-tuples of (SkippedResultColumnIndex: usize, ResultColumnIndexInOrderBySorter: usize)
/// If any result columns can be skipped, this returns list of 2-tuples of (SkippedResultColumnIndex: usize, ResultColumnIndexInOrderBySorter: usize)
fn order_by_deduplicate_result_columns(
order_by: &Vec<(ast::Expr, Direction)>,
result_columns: &Vec<ResultSetColumn>,