aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-01-31 05:44:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'Add quoted identifier test cases for ALTER TABLE' from Levy A.

Browse Source 
Resolves #2093
There is a small incompatibility on how we quote the added column on the
final schema, but doesn't change any behavior.

Closes #2943
This commit is contained in:
Pekka Enberg
2025-09-16 11:46:12 +03:00
committed by GitHub
parent 4b12ce954a 8867d8cdb6
commit 74331898a3
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/translate/alter.rs
View File

@@ -198,6 +198,7 @@ pub fn translate_alter_table(
}
}
// TODO: All quoted ids will be quoted with `[]`, we should store some info from the parsed AST
btree.columns.push(column.clone());
let sql = btree.to_sql();

16
testing/alter_table.test
View File

@@ -19,6 +19,14 @@ do_execsql_test_on_specific_db {:memory:} alter-table-rename-column {
"CREATE INDEX i ON t (b)"
}
do_execsql_test_on_specific_db {:memory:} alter-table-rename-quoted-column {
CREATE TABLE t (a INTEGER);
ALTER TABLE t RENAME a TO "ab cd";
SELECT sql FROM sqlite_schema;
} {
"CREATE TABLE t (\"ab cd\" INTEGER)"
}
do_execsql_test_on_specific_db {:memory:} alter-table-add-column {
CREATE TABLE t (a);
INSERT INTO t VALUES (1);
@@ -74,6 +82,14 @@ do_execsql_test_on_specific_db {:memory:} alter-table-add-column-default {
"0.1|hello"
}
do_execsql_test_on_specific_db {:memory:} alter-table-add-quoted-column {
CREATE TABLE test (a);
ALTER TABLE test ADD COLUMN [b c];
SELECT sql FROM sqlite_schema;
} {
"CREATE TABLE test (a, [b c])"
}
do_execsql_test_on_specific_db {:memory:} alter-table-drop-column {
CREATE TABLE t (a, b);
INSERT INTO t VALUES (1, 1), (2, 2), (3, 3);