aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-22 16:35:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

update vector slice to adhere to start..end and not start, length

Browse Source
This commit is contained in:
bit-aloo
2025-07-30 14:04:59 +05:30
parent c546261010
commit 6f45cb9770
3 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
COMPAT.md
View File

@@ -632,7 +632,7 @@ The `vector` extension is compatible with libSQL native vector search.
| vector_distance_cos(x, y) | Yes | |
| vector_distance_l2(x, y) | Yes |Euclidean distance|
| vector_concat(x, y) | Yes | |
| vector_slice(x, start_index, length) | Yes | |
| vector_slice(x, start_index, end_index) | Yes | |
### Time

10
core/vector/mod.rs
View File

@@ -142,18 +142,18 @@ pub fn vector_slice(args: &[Register]) -> Result<Value> {
.as_int()
.ok_or_else(|| LimboError::InvalidArgument("start index must be an integer".into()))?;
let length = args[2]
let end_index = args[2]
.get_owned_value()
.as_int()
.ok_or_else(|| LimboError::InvalidArgument("length must be an integer".into()))?;
.ok_or_else(|| LimboError::InvalidArgument("end_index must be an integer".into()))?;
if start_index < 0 || length < 0 {
if start_index < 0 || end_index < 0 {
return Err(LimboError::InvalidArgument(
"start index and length must be non-negative".into(),
"start index and end_index must be non-negative".into(),
));
}
let result = vector_types::vector_slice(&vector, start_index as usize, length as usize)?;
let result = vector_types::vector_slice(&vector, start_index as usize, end_index as usize)?;
Ok(match result.vector_type {
VectorType::Float32 => vector_serialize_f32(result),

21
core/vector/vector_types.rs
View File

@@ -334,21 +334,26 @@ pub fn vector_concat(v1: &Vector, v2: &Vector) -> Result<Vector> {
})
}
pub fn vector_slice(vector: &Vector, start_idx: usize, length: usize) -> Result<Vector> {
pub fn vector_slice(vector: &Vector, start_idx: usize, end_idx: usize) -> Result<Vector> {
fn extract_bytes<T, const N: usize>(
slice: &[T],
start: usize,
len: usize,
end: usize,
to_bytes: impl Fn(&T) -> [u8; N],
) -> Result<Vec<u8>> {
if start + len > slice.len() {
if start > end {
return Err(LimboError::InvalidArgument(
"start index must not be greater than end index".into(),
));
}
if end > slice.len() || start >= slice.len() {
return Err(LimboError::ConversionError(
"vector_slice range out of bounds".into(),
));
}
let mut buf = Vec::with_capacity(len * N);
for item in &slice[start..start + len] {
let mut buf = Vec::with_capacity((end - start) * N);
for item in &slice[start..end] {
buf.extend_from_slice(&to_bytes(item));
}
Ok(buf)
@@ -357,13 +362,13 @@ pub fn vector_slice(vector: &Vector, start_idx: usize, length: usize) -> Result<
let (vector_type, data) = match vector.vector_type {
VectorType::Float32 => (
VectorType::Float32,
extract_bytes::<f32, 4>(vector.as_f32_slice(), start_idx, length, |v| {
extract_bytes::<f32, 4>(vector.as_f32_slice(), start_idx, end_idx, |v| {
v.to_le_bytes()
})?,
),
VectorType::Float64 => (
VectorType::Float64,
extract_bytes::<f64, 8>(vector.as_f64_slice(), start_idx, length, |v| {
extract_bytes::<f64, 8>(vector.as_f64_slice(), start_idx, end_idx, |v| {
v.to_le_bytes()
})?,
),
@@ -371,7 +376,7 @@ pub fn vector_slice(vector: &Vector, start_idx: usize, length: usize) -> Result<
Ok(Vector {
vector_type,
dims: length,
dims: end_idx - start_idx,
data,
})
}