aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-31 15:04:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'Fix incorrect lossy conversion of Value::Blob to a utf-8 String' from Luca Muscat

Browse Source 
Hey 👋
I admire the work that you guys are doing here, great job so far!
`Value::Blob::encode_hex` incorrectly does a lossy conversion of the
blob's underlying byte vector into a utf8 String, incorrectly displaying
the underlying hex in the process.
This PR fixes issue #1751

Closes #1759
This commit is contained in:
Pekka Enberg
2025-06-17 11:36:55 +03:00
parent 15daa9e81a a5ac1884c1
commit 6aece7af2f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/vdbe/execute.rs
View File

@@ -5792,10 +5792,11 @@ impl Value {
pub fn exec_hex(&self) -> Value {
match self {
Value::Text(_) | Value::Integer(_) | Value::Float(_) | Value::Blob(_) => {
Value::Text(_) | Value::Integer(_) | Value::Float(_) => {
let text = self.to_string();
Value::build_text(&hex::encode_upper(text))
}
Value::Blob(blob_bytes) => Value::build_text(&hex::encode_upper(blob_bytes)),
_ => Value::Null,
}
}
@@ -7548,6 +7549,10 @@ mod tests {
let input_float = Value::Float(12.34);
let expected_val = Value::build_text("31322E3334");
assert_eq!(input_float.exec_hex(), expected_val);
let input_blob = Value::Blob(vec![0xff]);
let expected_val = Value::build_text("FF");
assert_eq!(input_blob.exec_hex(), expected_val);
}
#[test]