aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-01-23 09:54:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'core/translate: Return error if SELECT needs tables and there are none' from Mikaël Francoeur

Browse Source 
Fixes https://github.com/tursodatabase/turso/issues/1972

Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com>

Closes #2023
This commit is contained in:
Pekka Enberg
2025-07-10 14:02:57 +03:00
parent 7a259957ac 89b0574fac
commit 6749af7037
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/translate/select.rs
View File

@@ -206,6 +206,14 @@ fn prepare_one_select_plan(
let mut table_references = TableReferences::new(vec![], outer_query_refs.to_vec());
if from.is_none() {
for column in &columns {
if matches!(column, ResultColumn::Star) {
crate::bail_parse_error!("no tables specified");
}
}
}
// Parse the FROM clause into a vec of TableReferences. Fold all the join conditions expressions into the WHERE clause.
parse_from(
schema,

12
testing/select.test
View File

@@ -285,6 +285,18 @@ do_execsql_test_on_specific_db {:memory:} select-union-all-with-filters {
6
10}
do_execsql_test_error select-star-no-from {
SELECT *;
} {no tables specified}
do_execsql_test_error select-star-and-constant-no-from {
SELECT *, 1;
} {no tables specified}
do_execsql_test_error select-star-subquery {
SELECT 1 FROM (SELECT *);
} {no tables specified}
if {[info exists ::env(SQLITE_EXEC)] && ($::env(SQLITE_EXEC) eq "scripts/limbo-sqlite3-index-experimental" || $::env(SQLITE_EXEC) eq "sqlite3")} {
do_execsql_test_on_specific_db {:memory:} select-union-1 {
CREATE TABLE t(x TEXT, y TEXT);