aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-23 17:05:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor emit_fk_violation() to always issue a FkCounter instruction

Browse Source
This commit is contained in:
Jussi Saurio
2025-10-21 11:01:43 +03:00
parent 7b6667d079
commit 6557a41503
1 changed files with 8 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
core/translate/fkeys.rs
View File

@@ -212,19 +212,13 @@ pub fn build_index_affinity_string(idx: &Index, table: &BTreeTable) -> String {
.collect()
}
/// For deferred FKs: increment the global counter; for immediate FKs: halt with FK error.
/// Increment a foreign key violation counter; for deferred FKs, this is a global counter
/// on the connection; for immediate FKs, this is a per-statement counter in the program state.
pub fn emit_fk_violation(program: &mut ProgramBuilder, fk: &ForeignKey) -> Result<()> {
if fk.deferred {
program.emit_insn(Insn::FkCounter {
increment_value: 1,
is_scope: false,
});
} else {
program.emit_insn(Insn::Halt {
err_code: crate::error::SQLITE_CONSTRAINT_FOREIGNKEY,
description: "FOREIGN KEY constraint failed".to_string(),
});
}
program.emit_insn(Insn::FkCounter {
increment_value: 1,
is_scope: !fk.deferred,
});
Ok(())
}
@@ -549,16 +543,8 @@ fn emit_fk_parent_key_probe(
let on_match = |p: &mut ProgramBuilder| -> Result<()> {
match (is_deferred, pass) {
// OLD key referenced by a child
(false, ParentProbePass::Old) => {
// Immediate FK: fail now.
emit_fk_violation(p, &fk_ref.fk)?; // HALT for immediate
}
(true, ParentProbePass::Old) => {
// Deferred FK: increment counter.
p.emit_insn(Insn::FkCounter {
increment_value: 1,
is_scope: false,
});
(_, ParentProbePass::Old) => {
emit_fk_violation(p, &fk_ref.fk)?;
}
// NEW key referenced by a child (cancel one deferred violation)