aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-27 04:54:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'Fail simulator on parse errors' from Jussi Saurio

Browse Source 
Closes #2618 (sufficiently for now, IMO)
Prevents simulator from creating malformed queries which we don't notice
(ref e.g. #2609 , #2611, #2616)

Closes #2624
This commit is contained in:
Jussi Saurio
2025-08-17 14:40:38 +03:00
committed by GitHub
parent c21d9871db 0a3ebf8914
commit 5fc967c41d
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
simulator/generation/plan.rs
View File

@@ -451,6 +451,9 @@ impl Interaction {
&query_str[0..query_str.len().min(4096)],
err
);
if let Some(turso_core::LimboError::ParseError(e)) = err {
panic!("Unexpected parse error: {e}");
}
return Err(err.unwrap());
}
let rows = rows?;

12
simulator/generation/query.rs
View File

@@ -237,12 +237,20 @@ impl ArbitraryFrom<&SimulatorEnv> for Select {
let num_result_columns = rng.gen_range(1..=min_column_count_across_tables);
let first = SelectInner::arbitrary_sized_from(rng, env, num_result_columns);
let mut first = SelectInner::arbitrary_sized_from(rng, env, num_result_columns);
let rest: Vec<SelectInner> = (0..num_compound_selects)
let mut rest: Vec<SelectInner> = (0..num_compound_selects)
.map(|_| SelectInner::arbitrary_sized_from(rng, env, num_result_columns))
.collect();
if !rest.is_empty() {
// ORDER BY is not supported in compound selects yet
first.order_by = None;
for s in &mut rest {
s.order_by = None;
}
}
Self {
body: SelectBody {
select: Box::new(first),