aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2025-12-25 20:14:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix SELECT .. LIMIT not respecting the limit

Browse Source 
Fix the codegen to emit DecrJumpZero in the right place.
This commit is contained in:
Pekka Enberg
2024-06-30 19:11:45 +03:00
parent 1573844680
commit 5fbcdbb424
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/translate.rs
View File

@@ -110,7 +110,7 @@ fn translate_select(schema: &Schema, select: Select) -> Result<Program> {
&info_per_columns,
exist_aggregation,
);
if exist_aggregation {
let limit_decr_insn = if exist_aggregation {
// Only one ResultRow will occurr with aggregations.
program.emit_insn(Insn::NextAsync { cursor_id });
program.emit_insn(Insn::NextAwait {
@@ -142,18 +142,20 @@ fn translate_select(schema: &Schema, select: Select) -> Result<Program> {
register_start,
register_end,
});
None
} else {
program.emit_insn(Insn::ResultRow {
register_start,
register_end,
});
let limit_decr_insn = limit_reg.map(|_| program.emit_placeholder());
program.emit_insn(Insn::NextAsync { cursor_id });
program.emit_insn(Insn::NextAwait {
cursor_id,
pc_if_next: rewind_await_offset,
});
}
let limit_decr_insn = limit_reg.map(|_| program.emit_placeholder());
limit_decr_insn
};
program.fixup_insn(
rewind_await_offset,
Insn::RewindAwait {