Merge 'Remove unnecessary argument from Pager::end_tx()' from Nikita Sivukhin

No need to pass `disable` flag to the `end_tx` method as it has that
info from connection itself

Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com>

Closes #2777

core/lib.rs

@@ -1500,7 +1500,6 @@ impl Connection {
                     pager.end_tx(
                         true, // rollback = true for close
                         self,
-                        self.wal_auto_checkpoint_disabled.get(),
                     )
                 })?;
                 self.transaction_state.set(TransactionState::None);
@@ -2106,7 +2105,7 @@ impl Statement {
             }
             let state = self.program.connection.transaction_state.get();
             if let TransactionState::Write { .. } = state {
-                let end_tx_res = self.pager.end_tx(true, &self.program.connection, true)?;
+                let end_tx_res = self.pager.end_tx(true, &self.program.connection)?;
                 self.program
                     .connection
                     .transaction_state

core/mvcc/database/mod.rs

@@ -546,7 +546,6 @@ impl<Clock: LogicalClock> StateTransition for CommitStateMachine<Clock> {
                         .end_tx(
                             false, // rollback = false since we're committing
                             &self.connection,
-                            self.connection.wal_auto_checkpoint_disabled.get(),
                         )
                         .map_err(|e| LimboError::InternalError(e.to_string()))
                         .unwrap();

core/storage/btree.rs

@@ -7959,10 +7959,7 @@ mod tests {
                     pager.deref(),
                 )
                 .unwrap();
-                pager
-                    .io
-                    .block(|| pager.end_tx(false, &conn, false))
-                    .unwrap();
+                pager.io.block(|| pager.end_tx(false, &conn)).unwrap();
                 pager.begin_read_tx().unwrap();
                 // FIXME: add sorted vector instead, should be okay for small amounts of keys for now :P, too lazy to fix right now
                 let _c = cursor.move_to_root().unwrap();
@@ -8107,10 +8104,7 @@ mod tests {
                 if let Some(c) = c {
                     pager.io.wait_for_completion(c).unwrap();
                 }
-                pager
-                    .io
-                    .block(|| pager.end_tx(false, &conn, false))
-                    .unwrap();
+                pager.io.block(|| pager.end_tx(false, &conn)).unwrap();
             }
 
             // Check that all keys can be found by seeking
@@ -8316,10 +8310,7 @@ mod tests {
                 if let Some(c) = c {
                     pager.io.wait_for_completion(c).unwrap();
                 }
-                pager
-                    .io
-                    .block(|| pager.end_tx(false, &conn, false))
-                    .unwrap();
+                pager.io.block(|| pager.end_tx(false, &conn)).unwrap();
             }
 
             // Final validation

core/storage/pager.rs

@@ -1026,7 +1026,6 @@ impl Pager {
         &self,
         rollback: bool,
         connection: &Connection,
-        wal_auto_checkpoint_disabled: bool,
     ) -> Result<IOResult<PagerCommitResult>> {
         if connection.is_nested_stmt.get() {
             // Parent statement will handle the transaction rollback.
@@ -1050,7 +1049,8 @@ impl Pager {
             self.rollback(schema_did_change, connection, is_write)?;
             return Ok(IOResult::Done(PagerCommitResult::Rollback));
         }
-        let commit_status = return_if_io!(self.commit_dirty_pages(wal_auto_checkpoint_disabled));
+        let commit_status =
+            return_if_io!(self.commit_dirty_pages(connection.wal_auto_checkpoint_disabled.get()));
         wal.borrow().end_write_tx();
         wal.borrow().end_read_tx();
 

core/vdbe/execute.rs

@@ -2170,7 +2170,7 @@ pub fn op_auto_commit(
     if *auto_commit != conn.auto_commit.get() {
         if *rollback {
             // TODO(pere): add rollback I/O logic once we implement rollback journal
-            return_if_io!(pager.end_tx(true, &conn, false));
+            return_if_io!(pager.end_tx(true, &conn));
             conn.transaction_state.replace(TransactionState::None);
             conn.auto_commit.replace(true);
         } else {

core/vdbe/mod.rs

@@ -434,9 +434,7 @@ impl Program {
                 // Connection is closed for whatever reason, rollback the transaction.
                 let state = self.connection.transaction_state.get();
                 if let TransactionState::Write { .. } = state {
-                    pager
-                        .io
-                        .block(|| pager.end_tx(true, &self.connection, false))?;
+                    pager.io.block(|| pager.end_tx(true, &self.connection))?;
                 }
                 return Err(LimboError::InternalError("Connection closed".to_string()));
             }
@@ -608,11 +606,7 @@ impl Program {
         connection: &Connection,
         rollback: bool,
     ) -> Result<IOResult<()>> {
-        let cacheflush_status = pager.end_tx(
-            rollback,
-            connection,
-            connection.wal_auto_checkpoint_disabled.get(),
-        )?;
+        let cacheflush_status = pager.end_tx(rollback, connection)?;
         match cacheflush_status {
             IOResult::Done(_) => {
                 if self.change_cnt_on {
@@ -869,7 +863,7 @@ pub fn handle_program_error(
         _ => {
             pager
                 .io
-                .block(|| pager.end_tx(true, connection, false))
+                .block(|| pager.end_tx(true, connection))
                 .inspect_err(|e| {
                     tracing::error!("end_tx failed: {e}");
                 })?;