aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-23 08:55:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

core/vdbe: Don't call rowid() unless view processing is enabled

Browse Source 
Currently, the simulator complains of the following error:

```
Error: failed with error: 'attempt to multiply with overflow'
```

However, we don't enable views in the simulator so -- despite being an
issue -- we should never see this. Let's fix `op_delete()` some more not
to not even call rowid() unless view processing is enabled.
This commit is contained in:
Pekka Enberg
2025-08-11 10:56:58 +03:00
parent 6f3278f6ed
commit 3aa885690c
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
core/vdbe/execute.rs
View File

@@ -5291,19 +5291,18 @@ pub fn op_delete(
);
// Capture row data before deletion for view updates
let (key, record_values) = {
let record_key_and_values = {
let mut cursor = state.get_cursor(*cursor_id);
let cursor = cursor.as_btree_mut();
// Get the current key
let maybe_key = return_if_io!(cursor.rowid());
let key = maybe_key.ok_or_else(|| {
LimboError::InternalError("Cannot delete: no current row".to_string())
})?;
let schema = program.connection.schema.borrow();
let dependent_views = schema.get_dependent_views(table_name);
let record_values = if !dependent_views.is_empty() {
let result = if !dependent_views.is_empty() {
// Get the current key
let maybe_key = return_if_io!(cursor.rowid());
let key = maybe_key.ok_or_else(|| {
LimboError::InternalError("Cannot delete: no current row".to_string())
})?;
// Get the current record before deletion and extract values
if let Some(record) = return_if_io!(cursor.record()) {
let mut values = record
@@ -5320,7 +5319,7 @@ pub fn op_delete(
}
}
}
Some(values)
Some((key, values))
} else {
None
}
@@ -5331,11 +5330,11 @@ pub fn op_delete(
// Now perform the deletion
return_if_io!(cursor.delete());
(key, record_values)
result
};
// Update dependent views for incremental computation
if let Some(values) = record_values {
if let Some((key, values)) = record_key_and_values {
let schema = program.connection.schema.borrow();
let dependent_views = schema.get_dependent_views(table_name);
let mut tx_states = program.connection.view_transaction_states.borrow_mut();