Merge 'Add some comments for values statement' from meteorgan

follow up: #1549
simultaneously, address a warning in CI as the package `sqlite3-parser`
has been renamed to `limbo_sqlite3_parser`.

Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com>

Closes #1565
This commit is contained in:
Jussi Saurio
2025-05-23 17:30:30 +03:00
2 changed files with 2 additions and 1 deletions

View File

@@ -49,7 +49,7 @@ jobs:
- uses: actions/checkout@v3
- name: Clippy
run: |
cargo clippy --workspace --all-features --all-targets --exclude limbo-wasm --exclude sqlite3-parser -- -A clippy::all -W clippy::correctness -W clippy::perf -W clippy::suspicious --deny=warnings
cargo clippy --workspace --all-features --all-targets --exclude limbo-wasm --exclude limbo_sqlite3_parser -- -A clippy::all -W clippy::correctness -W clippy::perf -W clippy::suspicious --deny=warnings
- name: Clippy `limbo-wasm` crate `nodejs` feature
run: |
cargo clippy --package limbo-wasm --features nodejs --all-targets --no-deps -- -A clippy::all -W clippy::correctness -W clippy::perf -W clippy::suspicious --deny=warnings

View File

@@ -408,6 +408,7 @@ pub fn prepare_select_plan<'a>(
let mut result_columns = Vec::with_capacity(len);
for i in 0..len {
result_columns.push(ResultSetColumn {
// these result_columns work as placeholders for the values, so the expr doesn't matter
expr: ast::Expr::Literal(ast::Literal::Numeric(i.to_string())),
alias: None,
contains_aggregates: false,