mirror of
https://github.com/aljazceru/turso.git
synced 2026-01-07 18:24:20 +01:00
Merge 'Add some comments for values statement' from meteorgan
follow up: #1549 simultaneously, address a warning in CI as the package `sqlite3-parser` has been renamed to `limbo_sqlite3_parser`. Reviewed-by: Jussi Saurio <jussi.saurio@gmail.com> Closes #1565
This commit is contained in:
2
.github/workflows/rust.yml
vendored
2
.github/workflows/rust.yml
vendored
@@ -49,7 +49,7 @@ jobs:
|
||||
- uses: actions/checkout@v3
|
||||
- name: Clippy
|
||||
run: |
|
||||
cargo clippy --workspace --all-features --all-targets --exclude limbo-wasm --exclude sqlite3-parser -- -A clippy::all -W clippy::correctness -W clippy::perf -W clippy::suspicious --deny=warnings
|
||||
cargo clippy --workspace --all-features --all-targets --exclude limbo-wasm --exclude limbo_sqlite3_parser -- -A clippy::all -W clippy::correctness -W clippy::perf -W clippy::suspicious --deny=warnings
|
||||
- name: Clippy `limbo-wasm` crate `nodejs` feature
|
||||
run: |
|
||||
cargo clippy --package limbo-wasm --features nodejs --all-targets --no-deps -- -A clippy::all -W clippy::correctness -W clippy::perf -W clippy::suspicious --deny=warnings
|
||||
|
||||
@@ -408,6 +408,7 @@ pub fn prepare_select_plan<'a>(
|
||||
let mut result_columns = Vec::with_capacity(len);
|
||||
for i in 0..len {
|
||||
result_columns.push(ResultSetColumn {
|
||||
// these result_columns work as placeholders for the values, so the expr doesn't matter
|
||||
expr: ast::Expr::Literal(ast::Literal::Numeric(i.to_string())),
|
||||
alias: None,
|
||||
contains_aggregates: false,
|
||||
|
||||
Reference in New Issue
Block a user