aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-01-22 01:24:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'sqlite3: Fix compatibility test error by canonicalizing path' from Samuel Marks

Browse Source 
Use canonical path to fix temp path on macOS ; rename to resolve binding
connascence. Fixes:
```
---- tests::test_sqlite3_db_filename stdout ----

thread 'tests::test_sqlite3_db_filename' (62061) panicked at sqlite3/tests/compat/mod.rs:1251:13:
assertion `left == right` failed
  left: "/private/var/folders/w5/21g61wls7ksd3z8cxrj41s1c0000gn/T/.tmpNcCUO2.db"
 right: "/var/folders/w5/21g61wls7ksd3z8cxrj41s1c0000gn/T/.tmpNcCUO2.db"
```

Closes #3227
This commit is contained in:
Pekka Enberg
2025-09-22 09:15:00 +03:00
committed by GitHub
parent 46297acb31 d2cd48d9e4
commit 18c41b0f5a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sqlite3/tests/compat/mod.rs
View File

@@ -1247,8 +1247,10 @@ mod tests {
// Test with "main" database name
let filename = sqlite3_db_filename(db, c"main".as_ptr());
assert!(!filename.is_null());
let filename_str = std::ffi::CStr::from_ptr(filename).to_str().unwrap();
assert_eq!(filename_str, temp_file.path().to_str().unwrap());
let filename_pathbuf =
std::fs::canonicalize(std::ffi::CStr::from_ptr(filename).to_str().unwrap())
.unwrap();
assert_eq!(filename_pathbuf, temp_file.path().canonicalize().unwrap());
// Test with NULL database name (defaults to main)
let filename_default = sqlite3_db_filename(db, ptr::null());