aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-22 16:35:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix: check deferred FK violations before committing to WAL

Browse Source 
DEFERRED was a bit too deferred - it allowed the dirty pages to be
written out to WAL before checking for violations, resulting in the
violations effectively being committed even though the transaction
ended up aborting
This commit is contained in:
Jussi Saurio
2025-10-20 14:00:49 +03:00
parent bebe230b05
commit 10532544dc
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/vdbe/execute.rs
View File

@@ -2165,21 +2165,21 @@ pub fn halt(
let auto_commit = program.connection.auto_commit.load(Ordering::SeqCst);
tracing::trace!("halt(auto_commit={})", auto_commit);
if auto_commit {
let res = program.commit_txn(pager.clone(), state, mv_store, false);
if res.is_ok()
&& program.connection.foreign_keys_enabled()
// In autocommit mode, a statement that leaves deferred violations must fail here.
if program.connection.foreign_keys_enabled()
&& program
.connection
.fk_deferred_violations
.swap(0, Ordering::AcqRel)
> 0
{
// In autocommit mode, a statement that leaves deferred violations must fail here.
return Err(LimboError::Constraint(
"foreign key constraint failed".to_string(),
));
}
res.map(Into::into)
program
.commit_txn(pager.clone(), state, mv_store, false)
.map(Into::into)
} else {
Ok(InsnFunctionStepResult::Done)
}