aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-23 17:05:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

core: Tagging some comments as TODO

Browse Source
This commit is contained in:
Diego Reis
2025-06-03 10:53:45 -03:00
parent cf038b045d
commit 09f978b239
2 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/storage/sqlite3_ondisk.rs
View File

@@ -191,10 +191,12 @@ pub struct WalHeader {
/// Checkpoint sequence number. Increases with each checkpoint
pub checkpoint_seq: u32,
/// Random value used for the first salt in checksum calculations, incremented with each checkpoint
/// Random value used for the first salt in checksum calculations
/// TODO: Incremented with each checkpoint
pub salt_1: u32,
/// Random value used for the second salt in checksum calculations. A different random value for each checkpoint
/// Random value used for the second salt in checksum calculations.
/// TODO: A different random value for each checkpoint
pub salt_2: u32,
/// First checksum value in the wal-header

25
core/storage/wal.rs
View File

@@ -772,14 +772,23 @@ impl Wal for WalFile {
};
let everything_backfilled = shared.max_frame.load(Ordering::SeqCst)
== self.ongoing_checkpoint.max_frame;
if everything_backfilled && !matches!(mode, CheckpointMode::Passive) {
// Here we know that we backfilled everything, therefore we can safely
// reset the wal.
shared.frame_cache.lock().clear();
shared.pages_in_frames.lock().clear();
shared.max_frame.store(0, Ordering::SeqCst);
shared.nbackfills.store(0, Ordering::SeqCst);
// TODO(pere): truncate wal file here.
if everything_backfilled {
// TODO: Even in Passive mode, if everything was backfilled we should
// truncate and fsync the *db file*
// To properly reset the *wal file* we will need restart and/or truncate mode.
// Currently, it will grow the WAL file indefinetly, but don't resetting is better than breaking.
// Check: https://github.com/sqlite/sqlite/blob/2bd9f69d40dd240c4122c6d02f1ff447e7b5c098/src/wal.c#L2193
if !matches!(mode, CheckpointMode::Passive) {
// Here we know that we backfilled everything, therefore we can safely
// reset the wal.
shared.frame_cache.lock().clear();
shared.pages_in_frames.lock().clear();
shared.max_frame.store(0, Ordering::SeqCst);
shared.nbackfills.store(0, Ordering::SeqCst);
// TODO: if all frames were backfilled into the db file, calls fsync
// TODO(pere): truncate wal file here.
}
} else {
shared
.nbackfills