aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-01-21 17:14:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 'core/translate: remove unneessary agg clones' from Pere Diaz Bou

Browse Source 
```
Prepare `SELECT first_name, count(1) FROM users GROUP BY first_name HAVING count(1) > 1 ORDER BY cou...
                        time:   [3.9978 µs 4.0085 µs 4.0193 µs]
                        change: [-5.0734% -4.6271% -4.1644%] (p = 0.00 < 0.05)
```

Reviewed-by: Preston Thorpe <preston@turso.tech>

Closes #2846
This commit is contained in:
Preston Thorpe
2025-08-29 11:40:53 -04:00
committed by GitHub
parent dc34097581 167459389b
commit 0899711439
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/translate/select.rs
View File

@@ -392,7 +392,7 @@ fn prepare_one_select_plan(
original_expr: *expr.clone(),
distinctness,
};
aggregate_expressions.push(agg.clone());
aggregate_expressions.push(agg);
plan.result_columns.push(ResultSetColumn {
alias: maybe_alias.as_ref().map(|alias| match alias {
ast::As::Elided(alias) => {
@@ -455,7 +455,7 @@ fn prepare_one_select_plan(
original_expr: *expr.clone(),
distinctness,
};
aggregate_expressions.push(agg.clone());
aggregate_expressions.push(agg);
plan.result_columns.push(ResultSetColumn {
alias: maybe_alias.as_ref().map(|alias| {
match alias {
@@ -496,7 +496,7 @@ fn prepare_one_select_plan(
original_expr: *expr.clone(),
distinctness: Distinctness::NonDistinct,
};
aggregate_expressions.push(agg.clone());
aggregate_expressions.push(agg);
plan.result_columns.push(ResultSetColumn {
alias: maybe_alias.as_ref().map(|alias| match alias {
ast::As::Elided(alias) => {