aljaz/turso
1
0
Fork 0
mirror of https://github.com/aljazceru/turso.git synced 2026-02-02 14:54:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

implement write side of pragma schema_version

Browse Source 
It is insane that SQLite even allows this.
They actually don't if "defensive mode" is enabled:

"It is always safe to read the schema_version, but changing the
schema_version can cause problems. For this reason, attempts to change
the value of schema_version are a silent no-op when defensive mode is
enabled for a database connection.

Warning: Misuse of this pragma can result in database corruption."

We also update the compat table, which was not updated to reflect
the read version of this pragma being implemented.
This commit is contained in:
Glauber Costa
2025-07-19 20:39:30 -05:00
parent d1fdc7dbc8
commit 024d79fc0d
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
COMPAT.md
View File

@@ -156,7 +156,7 @@ Turso aims to be fully compatible with SQLite, with opt-in features not supporte
| PRAGMA read_uncommitted | No | |
| PRAGMA recursive_triggers | No | |
| PRAGMA reverse_unordered_selects | No | |
| PRAGMA schema_version | No | |
| PRAGMA schema_version | Yes | For writes, emulate defensive mode (always noop)|
| PRAGMA secure_delete | No | |
| PRAGMA short_column_names | Not Needed | deprecated in SQLite |
| PRAGMA shrink_memory | No | |

6
core/translate/pragma.rs
View File

@@ -133,8 +133,10 @@ fn update_pragma(
Ok((program, TransactionMode::Write))
}
PragmaName::SchemaVersion => {
// TODO: Implement updating schema_version
todo!("updating schema_version not yet implemented")
// SQLite allowing this to be set is an incredibly stupid idea in my view.
// In "defensive mode", this is a silent nop. So let's emulate that always.
program.emit_insn(Insn::Noop {});
Ok((program, TransactionMode::None))
}
PragmaName::TableInfo => {
// because we need control over the write parameter for the transaction,