fixed bug in "add/remove members to group" endpoint

* forgot to reference group
This commit is contained in:
Bernhard B
2022-03-25 19:11:32 +01:00
parent 13bd8cae9f
commit 60b4d8afbf

View File

@@ -699,7 +699,12 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members
} }
if group == nil { if group == nil {
return &NotFoundError{Description: "No group with that group id found"} return &NotFoundError{Description: "No group with that group id (" + groupId + ") found"}
}
internalGroupId, err := ConvertGroupIdToInternalGroupId(groupId)
if err != nil {
return errors.New("Invalid group id")
} }
if s.signalCliMode == JsonRpc { if s.signalCliMode == JsonRpc {
@@ -709,7 +714,7 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members
RemoveMembers []string `json:"remove-member,omitempty"` RemoveMembers []string `json:"remove-member,omitempty"`
GroupId string `json:"groupId"` GroupId string `json:"groupId"`
} }
request := Request{GroupId: groupId} request := Request{GroupId: internalGroupId}
if add { if add {
request.Members = append(request.Members, members...) request.Members = append(request.Members, members...)
} else { } else {
@@ -722,7 +727,7 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members
} }
_, err = jsonRpc2Client.getRaw("updateGroup", request) _, err = jsonRpc2Client.getRaw("updateGroup", request)
} else { } else {
cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup"} cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup", "-g", internalGroupId}
if add { if add {
cmd = append(cmd, "-m") cmd = append(cmd, "-m")