From 60b4d8afbfb4c0ef5c2d5cd893f662ea2c6d538f Mon Sep 17 00:00:00 2001 From: Bernhard B Date: Fri, 25 Mar 2022 19:11:32 +0100 Subject: [PATCH] fixed bug in "add/remove members to group" endpoint * forgot to reference group --- src/client/client.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/client/client.go b/src/client/client.go index 3b8a2a1..6361d28 100644 --- a/src/client/client.go +++ b/src/client/client.go @@ -699,7 +699,12 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members } if group == nil { - return &NotFoundError{Description: "No group with that group id found"} + return &NotFoundError{Description: "No group with that group id (" + groupId + ") found"} + } + + internalGroupId, err := ConvertGroupIdToInternalGroupId(groupId) + if err != nil { + return errors.New("Invalid group id") } if s.signalCliMode == JsonRpc { @@ -709,7 +714,7 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members RemoveMembers []string `json:"remove-member,omitempty"` GroupId string `json:"groupId"` } - request := Request{GroupId: groupId} + request := Request{GroupId: internalGroupId} if add { request.Members = append(request.Members, members...) } else { @@ -722,7 +727,7 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members } _, err = jsonRpc2Client.getRaw("updateGroup", request) } else { - cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup"} + cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup", "-g", internalGroupId} if add { cmd = append(cmd, "-m")