Fix segfault on recording with old FFmpeg

The AVPacket fields side_data and side_data_elems were not initialized by av_packet_ref() in old FFmpeg versions (prior to [1]). As a consequence, on av_packet_unref(), side_data was freed, causing a segfault. Fixes <https://github.com/Genymobile/scrcpy/issues/707> [1]: <http://git.videolan.org/gitweb.cgi/ffmpeg.git/?p=ffmpeg.git;a=commitdiff;h=3b4026e15110547892d5d770b6b43c9e34df458f>
Print gradle output on compiling
2026-03-05 19:54:41 +01:00 · 2019-08-13 18:58:36 +02:00 · 2019-08-09 15:15:28 +02:00 · 2019-08-08 23:24:47 +02:00 · 2019-08-08 17:17:48 -04:00
3 changed files with 7 additions and 1 deletions
--- a/app/src/recorder.c
+++ b/app/src/recorder.c
@@ -33,6 +33,11 @@ record_packet_new(const AVPacket *packet) {
    if (!rec) {
        return NULL;
    }
+
+    // av_packet_ref() does not initialize all fields in old FFmpeg versions
+    // See <https://github.com/Genymobile/scrcpy/issues/707>
+    av_init_packet(&rec->packet);
+
    if (av_packet_ref(&rec->packet, packet)) {
        SDL_free(rec);
        return NULL;
--- a/server/meson.build
+++ b/server/meson.build
@@ -6,6 +6,7 @@ if prebuilt_server == ''
                  build_always: true,  # gradle is responsible for tracking source changes
                  output: 'scrcpy-server.jar',
                  command: [find_program('./scripts/build-wrapper.sh'), meson.current_source_dir(), '@OUTPUT@', get_option('buildtype')],
+                  console: true,
                  install: true,
                  install_dir: 'share/scrcpy')
 else
--- a/server/src/main/java/com/genymobile/scrcpy/wrappers/WindowManager.java
+++ b/server/src/main/java/com/genymobile/scrcpy/wrappers/WindowManager.java
@@ -14,7 +14,7 @@ public final class WindowManager {
        try {
            Class<?> cls = manager.getClass();
            try {
-                return (Integer) manager.getClass().getMethod("getRotation").invoke(manager);
+                return (Integer) cls.getMethod("getRotation").invoke(manager);
            } catch (NoSuchMethodException e) {
                // method changed since this commit:
                // https://android.googlesource.com/platform/frameworks/base/+/8ee7285128c3843401d4c4d0412cd66e86ba49e3%5E%21/#F2
Author	SHA1	Message	Date
Romain Vimont	a9c8fa305d	Fix segfault on recording with old FFmpeg The AVPacket fields side_data and side_data_elems were not initialized by av_packet_ref() in old FFmpeg versions (prior to [1]). As a consequence, on av_packet_unref(), side_data was freed, causing a segfault. Fixes <https://github.com/Genymobile/scrcpy/issues/707> [1]: <http://git.videolan.org/gitweb.cgi/ffmpeg.git/?p=ffmpeg.git;a=commitdiff;h=3b4026e15110547892d5d770b6b43c9e34df458f>	2019-08-13 18:58:36 +02:00
Romain Vimont	20b3f101a4	Print gradle output on compiling Enable the attribute "console" of custom_target() introduced in meson 0.48. This allows to get a feedback of what gradle does (which can takes a very long time). This produces warnings because we declare to support meson >= 0.37, but we don't want to stop supporting older versions for that. Older versions just ignore the option: > WARNING: Unknown keyword arguments in target scrcpy-server: console Newer meson versions use it, but warn because we declare supporting older versions: > WARNING: Project targetting '>= 0.37' but tried to use feature > introduced in '0.48.0': console arg in custom_target Meson does not support conditional branches to suppress such warnings, so just keep the warnings.	2019-08-09 15:15:28 +02:00
Romain Vimont	686733023b	Merge pull request #708 from toddsierens/patch-1 Update WindowManager.java	2019-08-08 23:24:47 +02:00
toddsierens	27eacc3c11	Update WindowManager.java	2019-08-08 17:17:48 -04:00