Remove sc_str_quote()

It is no longer used.

PR #6663 <https://github.com/Genymobile/scrcpy/pull/6663>

app/meson.build

@@ -15,7 +15,6 @@ src = [
     'src/delay_buffer.c',
     'src/demuxer.c',
     'src/device_msg.c',
-    'src/disconnect.c',
     'src/events.c',
     'src/icon.c',
     'src/file_pusher.c',
@@ -192,7 +191,8 @@ executable('scrcpy', src,
 datadir = get_option('datadir') # by default 'share'
 
 install_man('scrcpy.1')
-install_data('data/scrcpy.png',
+install_data('data/icon.png',
+             rename: 'scrcpy.png',
              install_dir: datadir / 'icons/hicolor/256x256/apps')
 install_data('data/zsh-completion/_scrcpy',
              install_dir: datadir / 'zsh/site-functions')
@@ -289,6 +289,6 @@ endif
 
 if meson.version().version_compare('>= 0.58.0')
        devenv = environment()
-       devenv.set('SCRCPY_ICON_DIR', meson.current_source_dir() / 'data')
+       devenv.set('SCRCPY_ICON_PATH', meson.current_source_dir() / 'data/icon.png')
        meson.add_devenv(devenv)
 endif

app/scrcpy.1

@@ -851,8 +851,8 @@ Path to adb.
 Device serial to use if no selector (\fB-s\fR, \fB-d\fR, \fB-e\fR or \fB\-\-tcpip=\fIaddr\fR) is specified.
 
 .TP
-.B SCRCPY_ICON_DIR
-Path to the icon directory.
+.B SCRCPY_ICON_PATH
+Path to the program icon.
 
 .TP
 .B SCRCPY_SERVER_PATH

app/src/adb/adb_device.c

@@ -39,11 +39,5 @@ sc_adb_device_get_type(const char *serial) {
         return SC_ADB_DEVICE_TYPE_TCPIP;
     }
 
-    // TCP/IP devices provided by mDNS contain "adb-tls-connect"
-    // <https://github.com/Genymobile/scrcpy/issues/6248>
-    if (strstr(serial, "adb-tls-connect")) {
-        return SC_ADB_DEVICE_TYPE_TCPIP;
-    }
-
     return SC_ADB_DEVICE_TYPE_USB;
 }

app/src/adb/adb_parser.c

@@ -8,31 +8,6 @@
 #include "util/log.h"
 #include "util/str.h"
 
-static size_t
-rstrip_len(const char *s, size_t len) {
-    size_t i = len;
-
-    // Ignore trailing whitespaces
-    while (i > 0 && (s[i-1] == ' ' || s[i-1] == '\t')) {
-        --i;
-    }
-
-    return i;
-}
-
-static void
-locate_last_token(const char *s, size_t len, size_t *start, size_t *end) {
-    size_t i = rstrip_len(s, len);
-    *end = i; // excluded
-
-    // The token contains non-whitespace chars
-    while (i > 0 && (s[i-1] != ' ' && s[i-1] != '\t')) {
-        --i;
-    }
-
-    *start = i; // included
-}
-
 static bool
 sc_adb_parse_device(char *line, struct sc_adb_device *device) {
     // One device line looks like:
@@ -50,54 +25,64 @@ sc_adb_parse_device(char *line, struct sc_adb_device *device) {
         return false;
     }
 
-    size_t len = strlen(line);
+    char *s = line; // cursor in the line
 
-    size_t start;
-    size_t end;
-
-    // The serial (the first token) may contain spaces, which are also token
-    // separators. To avoid ambiguity, parse the string backwards:
-    //  - first, parse all the trailing key-value pairs (containing ':'),
-    //  - then, the preceding token (not containing ':') is the device state,
-    //  - finally, the remaining leading token is the device serial.
-    //
-    // Refs:
-    //  - <https://github.com/Genymobile/scrcpy/issues/6248>
-    //  - <https://github.com/Genymobile/scrcpy/issues/3537>
-    const char *state;
-    const char *model = NULL;
-    for (;;) {
-        locate_last_token(line, len, &start, &end);
-        if (start == end) {
-            // No more tokens, unexpected
-            return false;
-        }
-
-        const char *token = &line[start];
-        line[end] = '\0';
-
-        if (!strncmp("model:", token, sizeof("model:") - 1)) {
-            model = &token[sizeof("model:") - 1];
-            // We only need the model
-        } else if (!strchr(token, ':')) {
-            // The first non-key:value token, it's the device state
-            state = token;
-            break;
-        }
-
-        // Remove the trailing parts already handled
-        len = start;
-    }
-
-    assert(state);
-
-    size_t serial_len = rstrip_len(line, start);
+    // After the serial:
+    //  - "adb devices" writes a single '\t'
+    //  - "adb devices -l" writes multiple spaces
+    // For flexibility, accept both.
+    size_t serial_len = strcspn(s, " \t");
     if (!serial_len) {
         // empty serial
         return false;
     }
-    char *serial = line;
-    line[serial_len] = '\0';
+    bool eol = s[serial_len] == '\0';
+    if (eol) {
+        // serial alone is unexpected
+        return false;
+    }
+    s[serial_len] = '\0';
+    char *serial = s;
+    s += serial_len + 1;
+    // After the serial, there might be several spaces
+    s += strspn(s, " \t"); // consume all separators
+
+    size_t state_len = strcspn(s, " ");
+    if (!state_len) {
+        // empty state
+        return false;
+    }
+    eol = s[state_len] == '\0';
+    s[state_len] = '\0';
+    char *state = s;
+
+    char *model = NULL;
+    if (!eol) {
+        s += state_len + 1;
+
+        // Iterate over all properties "key:value key:value ..."
+        for (;;) {
+            size_t token_len = strcspn(s, " ");
+            if (!token_len) {
+                break;
+            }
+            eol = s[token_len] == '\0';
+            s[token_len] = '\0';
+            char *token = s;
+
+            if (!strncmp("model:", token, sizeof("model:") - 1)) {
+                model = &token[sizeof("model:") - 1];
+                // We only need the model
+                break;
+            }
+
+            if (eol) {
+                break;
+            } else {
+                s+= token_len + 1;
+            }
+        }
+    }
 
     device->serial = strdup(serial);
     if (!device->serial) {

app/src/cli.c

@@ -1249,8 +1249,8 @@ static const struct sc_envvar envvars[] = {
                 "--tcpip=<addr>) is specified",
     },
     {
-        .name = "SCRCPY_ICON_DIR",
-        .text = "Path to the icon directory",
+        .name = "SCRCPY_ICON_PATH",
+        .text = "Path to the program icon",
     },
     {
         .name = "SCRCPY_SERVER_PATH",

app/src/disconnect.c

@@ -1,89 +0,0 @@
-#include "disconnect.h"
-
-#include <assert.h>
-
-#include "icon.h"
-#include "util/log.h"
-
-static int
-run(void *userdata) {
-    struct sc_disconnect *d = userdata;
-
-    SDL_Surface *icon = sc_icon_load(SC_ICON_FILENAME_DISCONNECTED);
-    if (icon) {
-        d->cbs->on_icon_loaded(d, icon, d->cbs_userdata);
-    } else {
-        LOGE("Could not load disconnected icon");
-    }
-
-    if (d->deadline != SC_TICK_NONE) {
-        sc_mutex_lock(&d->mutex);
-        bool timed_out = false;
-        while (!d->interrupted && !timed_out) {
-            timed_out = !sc_cond_timedwait(&d->cond, &d->mutex, d->deadline);
-        }
-        sc_mutex_unlock(&d->mutex);
-
-        if (!d->interrupted) {
-            d->cbs->on_timeout(d, d->cbs_userdata);
-        }
-    }
-
-    return 0;
-}
-
-bool
-sc_disconnect_start(struct sc_disconnect *d, sc_tick deadline,
-                    const struct sc_disconnect_callbacks *cbs,
-                    void *cbs_userdata) {
-    bool ok = sc_mutex_init(&d->mutex);
-    if (!ok) {
-        return false;
-    }
-
-    ok = sc_cond_init(&d->cond);
-    if (!ok) {
-        goto error_destroy_mutex;
-    }
-
-    ok = sc_thread_create(&d->thread, run, "scrcpy-dis", d);
-    if (!ok) {
-        goto error_destroy_cond;
-    }
-
-    d->deadline = deadline;
-    d->interrupted = false;
-
-    assert(cbs && cbs->on_icon_loaded && cbs->on_timeout);
-    d->cbs = cbs;
-    d->cbs_userdata = cbs_userdata;
-
-    return true;
-
-error_destroy_mutex:
-    sc_mutex_destroy(&d->mutex);
-error_destroy_cond:
-    sc_cond_destroy(&d->cond);
-
-    return false;
-}
-
-void
-sc_disconnect_interrupt(struct sc_disconnect *d) {
-    sc_mutex_lock(&d->mutex);
-    d->interrupted = true;
-    sc_mutex_unlock(&d->mutex);
-    // wake up blocking wait
-    sc_cond_signal(&d->cond);
-}
-
-void
-sc_disconnect_join(struct sc_disconnect *d) {
-    sc_thread_join(&d->thread, NULL);
-}
-
-void
-sc_disconnect_destroy(struct sc_disconnect *d) {
-    sc_cond_destroy(&d->cond);
-    sc_mutex_destroy(&d->mutex);
-}

app/src/disconnect.h

@@ -1,47 +0,0 @@
-#ifndef SC_DISCONNECT
-#define SC_DISCONNECT
-
-#include "common.h"
-
-#include "SDL3/SDL_surface.h"
-#include "util/tick.h"
-#include "util/thread.h"
-
-// Tool to handle loading the icon and signal timeout when the device is
-// unexpectedly disconnected
-struct sc_disconnect {
-    sc_tick deadline;
-
-    struct sc_thread thread;
-    struct sc_mutex mutex;
-    struct sc_cond cond;
-    bool interrupted;
-
-    const struct sc_disconnect_callbacks *cbs;
-    void *cbs_userdata;
-};
-
-struct sc_disconnect_callbacks {
-    // Called when the disconnected icon is loaded
-    void (*on_icon_loaded)(struct sc_disconnect *d, SDL_Surface *icon,
-                           void *userdata);
-
-    // Called when the timeout expired (the scrcpy window must be closed)
-    void (*on_timeout)(struct sc_disconnect *d, void *userdata);
-};
-
-bool
-sc_disconnect_start(struct sc_disconnect *d, sc_tick deadline,
-                    const struct sc_disconnect_callbacks *cbs,
-                    void *cbs_userdata);
-
-void
-sc_disconnect_interrupt(struct sc_disconnect *d);
-
-void
-sc_disconnect_join(struct sc_disconnect *d);
-
-void
-sc_disconnect_destroy(struct sc_disconnect *d);
-
-#endif

app/src/events.c

@@ -6,13 +6,9 @@
 #include "util/thread.h"
 
 bool
-sc_push_event_impl(uint32_t type, void* ptr, const char *name) {
-    SDL_Event event = {
-        .user = {
-            .type = type,
-            .data1 = ptr,
-        }
-    };
+sc_push_event_impl(uint32_t type, const char *name) {
+    SDL_Event event;
+    event.type = type;
     bool ok = SDL_PushEvent(&event);
     if (!ok) {
         LOGE("Could not post %s event: %s", name, SDL_GetError());

app/src/events.h

@@ -13,20 +13,18 @@ enum {
     SC_EVENT_DEVICE_DISCONNECTED,
     SC_EVENT_SERVER_CONNECTION_FAILED,
     SC_EVENT_SERVER_CONNECTED,
+    SC_EVENT_USB_DEVICE_DISCONNECTED,
     SC_EVENT_DEMUXER_ERROR,
     SC_EVENT_RECORDER_ERROR,
     SC_EVENT_TIME_LIMIT_REACHED,
     SC_EVENT_CONTROLLER_ERROR,
     SC_EVENT_AOA_OPEN_ERROR,
-    SC_EVENT_DISCONNECTED_ICON_LOADED,
-    SC_EVENT_DISCONNECTED_TIMEOUT,
 };
 
 bool
-sc_push_event_impl(uint32_t type, void* ptr, const char *name);
+sc_push_event_impl(uint32_t type, const char *name);
 
-#define sc_push_event(TYPE) sc_push_event_impl(TYPE, NULL, # TYPE)
-#define sc_push_event_with_data(TYPE, PTR) sc_push_event_impl(TYPE, PTR, # TYPE)
+#define sc_push_event(TYPE) sc_push_event_impl(TYPE, # TYPE)
 
 typedef void (*sc_runnable_fn)(void *userdata);
 

app/src/icon.c

@@ -14,37 +14,33 @@
 
 #include "config.h"
 #include "util/env.h"
-#include "util/file.h"
+#ifdef PORTABLE
+# include "util/file.h"
+#endif
 #include "util/log.h"
 
-#define SCRCPY_DEFAULT_ICON_DIR PREFIX "/share/icons/hicolor/256x256/apps"
+#define SCRCPY_PORTABLE_ICON_FILENAME "icon.png"
+#define SCRCPY_DEFAULT_ICON_PATH \
+    PREFIX "/share/icons/hicolor/256x256/apps/scrcpy.png"
 
 static char *
-get_icon_path(const char *filename) {
-    char *icon_path;
-
-    char *icon_dir = sc_get_env("SCRCPY_ICON_DIR");
-    if (icon_dir) {
+get_icon_path(void) {
+    char *icon_path = sc_get_env("SCRCPY_ICON_PATH");
+    if (icon_path) {
         // if the envvar is set, use it
-        icon_path = sc_file_build_path(icon_dir, filename);
-        free(icon_dir);
-        if (!icon_path) {
-            LOG_OOM();
-            return NULL;
-        }
-        LOGD("Using icon from SCRCPY_ICON_DIR: %s", icon_path);
+        LOGD("Using SCRCPY_ICON_PATH: %s", icon_path);
         return icon_path;
     }
 
 #ifndef PORTABLE
-    icon_path = sc_file_build_path(SCRCPY_DEFAULT_ICON_DIR, filename);
+    LOGD("Using icon: " SCRCPY_DEFAULT_ICON_PATH);
+    icon_path = strdup(SCRCPY_DEFAULT_ICON_PATH);
     if (!icon_path) {
         LOG_OOM();
         return NULL;
     }
-    LOGD("Using icon: %s", icon_path);
 #else
-    icon_path = sc_file_get_local_path(filename);
+    icon_path = sc_file_get_local_path(SCRCPY_PORTABLE_ICON_FILENAME);
     if (!icon_path) {
         LOGE("Could not get icon path");
         return NULL;
@@ -181,7 +177,7 @@ to_sdl_pixel_format(enum AVPixelFormat fmt) {
 }
 
 static SDL_Surface *
-sc_icon_load_from_full_path(const char *path) {
+load_from_path(const char *path) {
     AVFrame *frame = decode_image(path);
     if (!frame) {
         return NULL;
@@ -278,19 +274,19 @@ error:
 }
 
 SDL_Surface *
-sc_icon_load(const char *filename) {
-    char *icon_path = get_icon_path(filename);
+scrcpy_icon_load(void) {
+    char *icon_path = get_icon_path();
     if (!icon_path) {
         return NULL;
     }
 
-    SDL_Surface *icon = sc_icon_load_from_full_path(icon_path);
+    SDL_Surface *icon = load_from_path(icon_path);
     free(icon_path);
     return icon;
 }
 
 void
-sc_icon_destroy(SDL_Surface *icon) {
+scrcpy_icon_destroy(SDL_Surface *icon) {
     SDL_PropertiesID props = SDL_GetSurfaceProperties(icon);
     assert(props);
     AVFrame *frame = SDL_GetPointerProperty(props, "sc_frame", NULL);

app/src/icon.h

@@ -5,13 +5,10 @@
 
 #include <SDL3/SDL_surface.h>
 
-#define SC_ICON_FILENAME_SCRCPY "scrcpy.png"
-#define SC_ICON_FILENAME_DISCONNECTED "disconnected.png"
-
 SDL_Surface *
-sc_icon_load(const char *filename);
+scrcpy_icon_load(void);
 
 void
-sc_icon_destroy(SDL_Surface *icon);
+scrcpy_icon_destroy(SDL_Surface *icon);
 
 #endif

app/src/scrcpy.c

@@ -173,9 +173,6 @@ event_loop(struct scrcpy *s, bool has_screen) {
         switch (event.type) {
             case SC_EVENT_DEVICE_DISCONNECTED:
                 LOGW("Device disconnected");
-                if (has_screen) {
-                    sc_screen_handle_event(&s->screen, &event);
-                }
                 return SCRCPY_EXIT_DISCONNECTED;
             case SC_EVENT_DEMUXER_ERROR:
                 LOGE("Demuxer error");
@@ -417,7 +414,6 @@ scrcpy(struct scrcpy_options *options) {
     bool screen_initialized = false;
     bool timeout_initialized = false;
     bool timeout_started = false;
-    bool disconnected = false;
 
     struct sc_acksync *acksync = NULL;
 
@@ -951,7 +947,14 @@ aoa_complete:
 
     ret = event_loop(s, options->window);
     terminate_event_loop();
-    disconnected = ret == SCRCPY_EXIT_DISCONNECTED;
+    LOGD("quit...");
+
+    if (options->window) {
+        // Close the window immediately on closing, because screen_destroy()
+        // may only be called once the video demuxer thread is joined (it may
+        // take time)
+        sc_screen_hide_window(&s->screen);
+    }
 
 end:
     if (timeout_started) {
@@ -996,17 +999,6 @@ end:
         sc_server_stop(&s->server);
     }
 
-    if (screen_initialized) {
-        if (disconnected) {
-            sc_screen_handle_disconnection(&s->screen);
-        }
-        LOGD("Quit...");
-
-        // Close the window immediately, because sc_screen_destroy() may only be
-        // called once the video demuxer thread is joined (it may take time)
-        sc_screen_hide_window(&s->screen);
-    }
-
     if (timeout_started) {
         sc_timeout_join(&s->timeout);
     }

app/src/screen.c

@@ -184,7 +184,7 @@ compute_content_rect(struct sc_size render_size, struct sc_size content_size,
 static void
 sc_screen_update_content_rect(struct sc_screen *screen) {
     // Only upscale video frames, not icon
-    bool can_upscale = screen->video && !screen->disconnected;
+    bool can_upscale = screen->video;
 
     struct sc_size render_size =
         sc_sdl_get_render_output_size(screen->renderer);
@@ -210,9 +210,7 @@ sc_screen_render(struct sc_screen *screen, bool update_content_rect) {
     bool ok = false;
     SDL_Texture *texture = screen->tex.texture;
     if (!texture) {
-        if (!screen->disconnected) {
-            LOGW("No texture to render");
-        }
+        LOGW("No texture to render");
         goto end;
     }
 
@@ -348,8 +346,6 @@ sc_screen_init(struct sc_screen *screen,
     screen->paused = false;
     screen->resume_frame = NULL;
     screen->orientation = SC_ORIENTATION_0;
-    screen->disconnected = false;
-    screen->disconnect_started = false;
 
     screen->video = params->video;
     screen->camera = params->camera;
@@ -461,7 +457,7 @@ sc_screen_init(struct sc_screen *screen,
         goto error_destroy_texture;
     }
 
-    SDL_Surface *icon = sc_icon_load(SC_ICON_FILENAME_SCRCPY);
+    SDL_Surface *icon = scrcpy_icon_load();
     if (icon) {
         if (!SDL_SetWindowIcon(screen->window, icon)) {
             LOGW("Could not set window icon: %s", SDL_GetError());
@@ -476,7 +472,7 @@ sc_screen_init(struct sc_screen *screen,
             }
         }
 
-        sc_icon_destroy(icon);
+        scrcpy_icon_destroy(icon);
     } else {
         // not fatal
         LOGE("Could not load icon");
@@ -607,19 +603,9 @@ sc_screen_interrupt(struct sc_screen *screen) {
     sc_fps_counter_interrupt(&screen->fps_counter);
 }
 
-static void
-sc_screen_interrupt_disconnect(struct sc_screen *screen) {
-    if (screen->disconnect_started) {
-        sc_disconnect_interrupt(&screen->disconnect);
-    }
-}
-
 void
 sc_screen_join(struct sc_screen *screen) {
     sc_fps_counter_join(&screen->fps_counter);
-    if (screen->disconnect_started) {
-        sc_disconnect_join(&screen->disconnect);
-    }
 }
 
 void
@@ -627,9 +613,6 @@ sc_screen_destroy(struct sc_screen *screen) {
 #ifndef NDEBUG
     assert(!screen->open);
 #endif
-    if (screen->disconnect_started) {
-        sc_disconnect_destroy(&screen->disconnect);
-    }
     sc_texture_destroy(&screen->tex);
     av_frame_free(&screen->frame);
 #ifdef SC_DISPLAY_FORCE_OPENGL_CORE_PROFILE
@@ -869,27 +852,6 @@ sc_screen_resize_to_pixel_perfect(struct sc_screen *screen) {
                                             content_size.height);
 }
 
-static void
-sc_disconnect_on_icon_loaded(struct sc_disconnect *d, SDL_Surface *icon,
-                             void *userdata) {
-    (void) d;
-    (void) userdata;
-
-    bool ok = sc_push_event_with_data(SC_EVENT_DISCONNECTED_ICON_LOADED, icon);
-    if (!ok) {
-        sc_icon_destroy(icon);
-    }
-}
-
-static void
-sc_disconnect_on_timeout(struct sc_disconnect *d, void *userdata) {
-    (void) d;
-    (void) userdata;
-
-    bool ok = sc_push_event(SC_EVENT_DISCONNECTED_TIMEOUT);
-    (void) ok; // ignore failure
-}
-
 void
 sc_screen_handle_event(struct sc_screen *screen, const SDL_Event *event) {
     // !video implies !has_video_window
@@ -929,29 +891,6 @@ sc_screen_handle_event(struct sc_screen *screen, const SDL_Event *event) {
                 apply_pending_resize(screen);
                 sc_screen_render(screen, true);
             }
-            return;
-        case SC_EVENT_DEVICE_DISCONNECTED:
-            assert(!screen->disconnected);
-            screen->disconnected = true;
-            if (!screen->has_video_window) {
-                // No window open
-                return;
-            }
-
-            sc_texture_reset(&screen->tex);
-            sc_screen_render(screen, true);
-
-            sc_tick deadline = sc_tick_now() + SC_TICK_FROM_SEC(2);
-            static const struct sc_disconnect_callbacks cbs = {
-                .on_icon_loaded = sc_disconnect_on_icon_loaded,
-                .on_timeout = sc_disconnect_on_timeout,
-            };
-            bool ok =
-                sc_disconnect_start(&screen->disconnect, deadline, &cbs, NULL);
-            if (ok) {
-                screen->disconnect_started = true;
-            }
-
             return;
     }
 
@@ -964,46 +903,6 @@ sc_screen_handle_event(struct sc_screen *screen, const SDL_Event *event) {
     sc_input_manager_handle_event(&screen->im, event);
 }
 
-void
-sc_screen_handle_disconnection(struct sc_screen *screen) {
-    if (!screen->has_video_window) {
-        // No window open, quit immediately
-        return;
-    }
-
-    SDL_Event event;
-    while (SDL_WaitEvent(&event)) {
-        switch (event.type) {
-            case SC_EVENT_DISCONNECTED_ICON_LOADED: {
-                SDL_Surface *icon_disconnected = event.user.data1;
-                assert(icon_disconnected);
-
-                bool ok = sc_texture_set_from_surface(&screen->tex, icon_disconnected);
-                if (ok) {
-                    screen->content_size.width = icon_disconnected->w;
-                    screen->content_size.height = icon_disconnected->h;
-                    sc_screen_render(screen, true);
-                } else {
-                    // not fatal
-                    LOGE("Could not set disconnected icon");
-                }
-
-                sc_icon_destroy(icon_disconnected);
-                break;
-            }
-            case SC_EVENT_DISCONNECTED_TIMEOUT:
-                LOGD("Closing after device disconnection");
-                goto end;
-            case SDL_EVENT_QUIT:
-                LOGD("User requested to quit");
-                goto end;
-        }
-    }
-
-end:
-    sc_screen_interrupt_disconnect(screen);
-}
-
 struct sc_point
 sc_screen_convert_drawable_to_frame_coords(struct sc_screen *screen,
                                            int32_t x, int32_t y) {

app/src/screen.h

@@ -12,7 +12,6 @@
 
 #include "controller.h"
 #include "coords.h"
-#include "disconnect.h"
 #include "fps_counter.h"
 #include "frame_buffer.h"
 #include "input_manager.h"
@@ -78,10 +77,6 @@ struct sc_screen {
 
     bool paused;
     AVFrame *resume_frame;
-
-    bool disconnected;
-    bool disconnect_started;
-    struct sc_disconnect disconnect;
 };
 
 struct sc_screen_params {
@@ -121,7 +116,7 @@ bool
 sc_screen_init(struct sc_screen *screen, const struct sc_screen_params *params);
 
 // request to interrupt any inner thread
-// must be called before sc_screen_join()
+// must be called before screen_join()
 void
 sc_screen_interrupt(struct sc_screen *screen);
 
@@ -165,10 +160,6 @@ sc_screen_set_paused(struct sc_screen *screen, bool paused);
 void
 sc_screen_handle_event(struct sc_screen *screen, const SDL_Event *event);
 
-// run the event loop once the device is disconnected
-void
-sc_screen_handle_disconnection(struct sc_screen *screen);
-
 // convert point from window coordinates to frame coordinates
 // x and y are expressed in pixels
 struct sc_point

app/src/texture.c

@@ -225,11 +225,3 @@ sc_texture_set_from_surface(struct sc_texture *tex, SDL_Surface *surface) {
 
     return true;
 }
-
-void
-sc_texture_reset(struct sc_texture *tex) {
-    if (tex->texture) {
-        SDL_DestroyTexture(tex->texture);
-        tex->texture = NULL;
-    }
-}

app/src/texture.h

@@ -41,7 +41,4 @@ sc_texture_set_from_frame(struct sc_texture *tex, const AVFrame *frame);
 bool
 sc_texture_set_from_surface(struct sc_texture *tex, SDL_Surface *surface);
 
-void
-sc_texture_reset(struct sc_texture *tex);
-
 #endif

app/src/usb/scrcpy_otg.c

@@ -31,7 +31,7 @@ sc_usb_on_disconnected(struct sc_usb *usb, void *userdata) {
     (void) usb;
     (void) userdata;
 
-    sc_push_event(SC_EVENT_DEVICE_DISCONNECTED);
+    sc_push_event(SC_EVENT_USB_DEVICE_DISCONNECTED);
 }
 
 static enum scrcpy_exit_code
@@ -39,9 +39,8 @@ event_loop(struct scrcpy_otg *s) {
     SDL_Event event;
     while (SDL_WaitEvent(&event)) {
         switch (event.type) {
-            case SC_EVENT_DEVICE_DISCONNECTED:
+            case SC_EVENT_USB_DEVICE_DISCONNECTED:
                 LOGW("Device disconnected");
-                sc_screen_handle_event(&s->screen, &event);
                 return SCRCPY_EXIT_DISCONNECTED;
             case SC_EVENT_AOA_OPEN_ERROR:
                 LOGE("AOA open error");
@@ -97,7 +96,6 @@ scrcpy_otg(struct scrcpy_options *options) {
     bool aoa_started = false;
     bool aoa_initialized = false;
     bool screen_initialized = false;
-    bool disconnected = false;
 
 #ifdef _WIN32
     // On Windows, only one process could open a USB device
@@ -223,7 +221,7 @@ scrcpy_otg(struct scrcpy_options *options) {
     usb_device_initialized = false;
 
     ret = event_loop(s);
-    disconnected = ret == SCRCPY_EXIT_DISCONNECTED;
+    LOGD("quit...");
 
 end:
     if (aoa_started) {
@@ -233,14 +231,6 @@ end:
 
     if (screen_initialized) {
         sc_screen_interrupt(&s->screen);
-
-        if (disconnected) {
-            sc_screen_handle_disconnection(&s->screen);
-        }
-        LOGD("Quit...");
-
-        // Close the window immediately
-        sc_screen_hide_window(&s->screen);
     }
 
     if (mp) {

app/src/util/command.c

@@ -17,8 +17,7 @@ sc_command_serialize_windows(const char *const argv[]) {
 
 #define BUF_PUSH(C) \
     do { \
-        ok = sc_strbuf_append_char(&buf, C); \
-        if (!ok) { \
+        if (!sc_strbuf_append_char(&buf, C)) { \
             goto end; \
         } \
     } while (0)

app/src/util/file.c

@@ -5,25 +5,6 @@
 
 #include "util/log.h"
 
-char *
-sc_file_build_path(const char *dir, const char *name) {
-    size_t dir_len = strlen(dir);
-    size_t name_len = strlen(name);
-
-    size_t len = dir_len + name_len + 2; // +2: '/' and '\0'
-    char *path = malloc(len);
-    if (!path) {
-        LOG_OOM();
-        return NULL;
-    }
-
-    memcpy(path, dir, dir_len);
-    path[dir_len] = SC_PATH_SEPARATOR;
-    // namelen + 1 to copy the final '\0'
-    memcpy(&path[dir_len + 1], name, name_len + 1);
-    return path;
-}
-
 char *
 sc_file_get_local_path(const char *name) {
     char *executable_path = sc_file_get_executable_path();
@@ -44,9 +25,24 @@ sc_file_get_local_path(const char *name) {
 
     *p = '\0'; // modify executable_path in place
     char *dir = executable_path;
-    char *file_path = sc_file_build_path(dir, name);
+    size_t dirlen = strlen(dir);
+    size_t namelen = strlen(name);
+
+    size_t len = dirlen + namelen + 2; // +2: '/' and '\0'
+    char *file_path = malloc(len);
+    if (!file_path) {
+        LOG_OOM();
+        free(executable_path);
+        return NULL;
+    }
+
+    memcpy(file_path, dir, dirlen);
+    file_path[dirlen] = SC_PATH_SEPARATOR;
+    // namelen + 1 to copy the final '\0'
+    memcpy(&file_path[dirlen + 1], name, namelen + 1);
 
     free(executable_path);
 
     return file_path;
 }
+

app/src/util/file.h

@@ -40,15 +40,6 @@ sc_file_get_executable_path(void);
 char *
 sc_file_get_local_path(const char *name);
 
-/**
- * Return the concatenation of dir, the path separator and the filename.
- *
- * The result must be freed by the caller using free(). It may return NULL on
- * error.
- */
-char *
-sc_file_build_path(const char *dir, const char *filename);
-
 /**
  * Indicate if the file exists and is not a directory
  */

app/src/util/log.c

@@ -151,6 +151,10 @@ sc_sdl_log_print(void *userdata, int category, SDL_LogPriority priority,
 
 void
 sc_log_configure(void) {
+#ifdef _WIN32
+    SetConsoleOutputCP(CP_UTF8);
+#endif
+
     SDL_SetLogOutputFunction(sc_sdl_log_print, NULL);
     // Redirect FFmpeg logs to SDL logs
     av_log_set_callback(sc_av_log_callback);

app/src/util/tick.h

@@ -6,7 +6,6 @@
 #include <stdint.h>
 
 typedef int64_t sc_tick;
-#define SC_TICK_NONE INT64_MIN
 #define PRItick PRIi64
 #define SC_TICK_FREQ 1000000 // microsecond
 

app/tests/test_adb_parser.c

@@ -163,25 +163,6 @@ static void test_adb_devices_spaces(void) {
     sc_adb_devices_destroy(&vec);
 }
 
-static void test_adb_devices_serial_with_spaces(void) {
-    char output[] =
-        "List of devices attached\n"
-        "adb-AEORQMSAOWNQ-N7Ger8 (2)._adb-tls-connect._tcp device "
-        "product:blazer model:Pixel_10_Pro device:blazer transport_id:3\n";
-
-    struct sc_vec_adb_devices vec = SC_VECTOR_INITIALIZER;
-    bool ok = sc_adb_parse_devices(output, &vec);
-    assert(ok);
-    assert(vec.size == 1);
-
-    struct sc_adb_device *device = &vec.data[0];
-    assert(!strcmp("adb-AEORQMSAOWNQ-N7Ger8 (2)._adb-tls-connect._tcp", device->serial));
-    assert(!strcmp("device", device->state));
-    assert(!strcmp("Pixel_10_Pro", device->model));
-
-    sc_adb_devices_destroy(&vec);
-}
-
 static void test_get_ip_single_line(void) {
     char ip_route[] = "192.168.1.0/24 dev wlan0  proto kernel  scope link  src "
                       "192.168.12.34\r\r\n";
@@ -284,7 +265,6 @@ int main(int argc, char *argv[]) {
     test_adb_devices_without_header();
     test_adb_devices_corrupted();
     test_adb_devices_spaces();
-    test_adb_devices_serial_with_spaces();
 
     test_get_ip_single_line();
     test_get_ip_single_line_without_eol();

release/build_linux.sh

@@ -38,6 +38,6 @@ ninja -C "$LINUX_BUILD_DIR"
 # Group intermediate outputs into a 'dist' directory
 mkdir -p "$LINUX_BUILD_DIR/dist"
 cp "$LINUX_BUILD_DIR"/app/scrcpy "$LINUX_BUILD_DIR/dist/"
-cp app/data/scrcpy.png "$LINUX_BUILD_DIR/dist/"
+cp app/data/icon.png "$LINUX_BUILD_DIR/dist/"
 cp app/scrcpy.1 "$LINUX_BUILD_DIR/dist/"
 cp -r "$ADB_INSTALL_DIR"/. "$LINUX_BUILD_DIR/dist/"

release/build_macos.sh

@@ -38,6 +38,6 @@ ninja -C "$MACOS_BUILD_DIR"
 # Group intermediate outputs into a 'dist' directory
 mkdir -p "$MACOS_BUILD_DIR/dist"
 cp "$MACOS_BUILD_DIR"/app/scrcpy "$MACOS_BUILD_DIR/dist/"
-cp app/data/scrcpy.png "$MACOS_BUILD_DIR/dist/"
+cp app/data/icon.png "$MACOS_BUILD_DIR/dist/"
 cp app/scrcpy.1 "$MACOS_BUILD_DIR/dist/"
 cp -r "$ADB_INSTALL_DIR"/. "$MACOS_BUILD_DIR/dist/"

release/build_windows.sh

@@ -47,7 +47,7 @@ mkdir -p "$WINXX_BUILD_DIR/dist"
 cp "$WINXX_BUILD_DIR"/app/scrcpy.exe "$WINXX_BUILD_DIR/dist/"
 cp app/data/scrcpy-console.bat "$WINXX_BUILD_DIR/dist/"
 cp app/data/scrcpy-noconsole.vbs "$WINXX_BUILD_DIR/dist/"
-cp app/data/scrcpy.png "$WINXX_BUILD_DIR/dist/"
+cp app/data/icon.png "$WINXX_BUILD_DIR/dist/"
 cp app/data/open_a_terminal_here.bat "$WINXX_BUILD_DIR/dist/"
 cp "$DEPS_INSTALL_DIR"/bin/*.dll "$WINXX_BUILD_DIR/dist/"
 cp -r "$ADB_INSTALL_DIR"/. "$WINXX_BUILD_DIR/dist/"

run

@@ -20,6 +20,6 @@ then
     exit 1
 fi
 
-SCRCPY_ICON_DIR="app/data" \
+SCRCPY_ICON_PATH="app/data/icon.png" \
 SCRCPY_SERVER_PATH="$BUILDDIR/server/scrcpy-server" \
 "$BUILDDIR/app/scrcpy" "$@"