Delete old TODOs

This commit is contained in:
Sergi Delgado Segura
2019-12-05 11:34:44 +01:00
parent b4197aa5bb
commit 5f7cd7e189
4 changed files with 1 additions and 7 deletions

View File

@@ -8,8 +8,6 @@ from pisa.logger import Logger
logger = Logger("Cryptographer") logger = Logger("Cryptographer")
# FIXME: Cryptographer is assuming AES-128-GCM and SHA256 since they are the only pair accepted by the encrypted blob
# and the only pair programmed so far.
class Cryptographer: class Cryptographer:
@staticmethod @staticmethod
# ToDo: #20-test-tx-decrypting-edge-cases # ToDo: #20-test-tx-decrypting-edge-cases

View File

@@ -53,7 +53,6 @@ class Cleaner:
confirmations=confirmations, confirmations=confirmations,
) )
# ToDo: #9-add-data-persistence
justice_txid = jobs[uuid].justice_txid justice_txid = jobs[uuid].justice_txid
locator = jobs[uuid].locator locator = jobs[uuid].locator
jobs.pop(uuid) jobs.pop(uuid)

View File

@@ -134,8 +134,7 @@ class Responder:
self.zmq_subscriber.handle(self.block_queue) self.zmq_subscriber.handle(self.block_queue)
def do_watch(self): def do_watch(self):
# ToDo: #9-add-data-persistence # ToDo: change prev_block_hash to the last known tip when bootstrapping
# change prev_block_hash to the last known tip when bootstrapping
prev_block_hash = BlockProcessor.get_best_block_hash() prev_block_hash = BlockProcessor.get_best_block_hash()
while len(self.jobs) > 0: while len(self.jobs) > 0:
@@ -150,7 +149,6 @@ class Responder:
"New block received", block_hash=block_hash, prev_block_hash=block.get("previousblockhash"), txs=txs "New block received", block_hash=block_hash, prev_block_hash=block.get("previousblockhash"), txs=txs
) )
# ToDo: #9-add-data-persistence
if prev_block_hash == block.get("previousblockhash"): if prev_block_hash == block.get("previousblockhash"):
self.check_confirmations(txs) self.check_confirmations(txs)

View File

@@ -10,7 +10,6 @@ encrypted_data = "8f31028097a8bf12a92e088caab5cf3fcddf0d35ed2b72c24b12269373efcd
encrypted_blob = EncryptedBlob(encrypted_data) encrypted_blob = EncryptedBlob(encrypted_data)
# TODO: The decryption tests are assuming the cipher is AES-GCM-128, since EncryptedBlob assumes the same. Fix this.
def test_decrypt_wrong_data(): def test_decrypt_wrong_data():
random_key = get_random_value_hex(32) random_key = get_random_value_hex(32)
random_encrypted_data = get_random_value_hex(64) random_encrypted_data = get_random_value_hex(64)