From 5f7cd7e18962246463a91bfbbd13df5d7bd15c06 Mon Sep 17 00:00:00 2001 From: Sergi Delgado Segura Date: Thu, 5 Dec 2019 11:34:44 +0100 Subject: [PATCH] Delete old TODOs --- common/cryptographer.py | 2 -- pisa/cleaner.py | 1 - pisa/responder.py | 4 +--- test/unit/test_cryptographer.py | 1 - 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/common/cryptographer.py b/common/cryptographer.py index 79da257..0256be2 100644 --- a/common/cryptographer.py +++ b/common/cryptographer.py @@ -8,8 +8,6 @@ from pisa.logger import Logger logger = Logger("Cryptographer") -# FIXME: Cryptographer is assuming AES-128-GCM and SHA256 since they are the only pair accepted by the encrypted blob -# and the only pair programmed so far. class Cryptographer: @staticmethod # ToDo: #20-test-tx-decrypting-edge-cases diff --git a/pisa/cleaner.py b/pisa/cleaner.py index 88177bc..3de9693 100644 --- a/pisa/cleaner.py +++ b/pisa/cleaner.py @@ -53,7 +53,6 @@ class Cleaner: confirmations=confirmations, ) - # ToDo: #9-add-data-persistence justice_txid = jobs[uuid].justice_txid locator = jobs[uuid].locator jobs.pop(uuid) diff --git a/pisa/responder.py b/pisa/responder.py index 5392864..fe59e8c 100644 --- a/pisa/responder.py +++ b/pisa/responder.py @@ -134,8 +134,7 @@ class Responder: self.zmq_subscriber.handle(self.block_queue) def do_watch(self): - # ToDo: #9-add-data-persistence - # change prev_block_hash to the last known tip when bootstrapping + # ToDo: change prev_block_hash to the last known tip when bootstrapping prev_block_hash = BlockProcessor.get_best_block_hash() while len(self.jobs) > 0: @@ -150,7 +149,6 @@ class Responder: "New block received", block_hash=block_hash, prev_block_hash=block.get("previousblockhash"), txs=txs ) - # ToDo: #9-add-data-persistence if prev_block_hash == block.get("previousblockhash"): self.check_confirmations(txs) diff --git a/test/unit/test_cryptographer.py b/test/unit/test_cryptographer.py index 9d488df..9c7c198 100644 --- a/test/unit/test_cryptographer.py +++ b/test/unit/test_cryptographer.py @@ -10,7 +10,6 @@ encrypted_data = "8f31028097a8bf12a92e088caab5cf3fcddf0d35ed2b72c24b12269373efcd encrypted_blob = EncryptedBlob(encrypted_data) -# TODO: The decryption tests are assuming the cipher is AES-GCM-128, since EncryptedBlob assumes the same. Fix this. def test_decrypt_wrong_data(): random_key = get_random_value_hex(32) random_encrypted_data = get_random_value_hex(64)