fix: update max visible height in list tests (#1269)

This commit is contained in:
Rico Sta. Cruz
2025-07-24 10:49:15 +10:00
committed by GitHub
parent 3fdd23df16
commit 8f0644e35b

View File

@@ -34,7 +34,7 @@ func createTestList() *listComponent[testItem] {
}
list := NewListComponent(
WithItems(items),
WithMaxVisibleItems[testItem](5),
WithMaxVisibleHeight[testItem](5),
WithFallbackMessage[testItem]("empty"),
WithAlphaNumericKeys[testItem](false),
WithRenderFunc(
@@ -45,9 +45,6 @@ func createTestList() *listComponent[testItem] {
WithSelectableFunc(func(item testItem) bool {
return item.Selectable()
}),
WithHeightFunc(func(item testItem, isFirstInViewport bool) int {
return 1
}),
)
return list.(*listComponent[testItem])
@@ -84,7 +81,7 @@ func TestJKKeyNavigation(t *testing.T) {
// Create list with alpha keys enabled
list := NewListComponent(
WithItems(items),
WithMaxVisibleItems[testItem](5),
WithMaxVisibleHeight[testItem](5),
WithFallbackMessage[testItem]("empty"),
WithAlphaNumericKeys[testItem](true),
WithRenderFunc(
@@ -95,9 +92,6 @@ func TestJKKeyNavigation(t *testing.T) {
WithSelectableFunc(func(item testItem) bool {
return item.Selectable()
}),
WithHeightFunc(func(item testItem, isFirstInViewport bool) int {
return 1
}),
)
// Test j key (down)
@@ -176,7 +170,7 @@ func TestNavigationBoundaries(t *testing.T) {
func TestEmptyList(t *testing.T) {
emptyList := NewListComponent(
WithItems([]testItem{}),
WithMaxVisibleItems[testItem](5),
WithMaxVisibleHeight[testItem](5),
WithFallbackMessage[testItem]("empty"),
WithAlphaNumericKeys[testItem](false),
WithRenderFunc(
@@ -187,9 +181,6 @@ func TestEmptyList(t *testing.T) {
WithSelectableFunc(func(item testItem) bool {
return item.Selectable()
}),
WithHeightFunc(func(item testItem, isFirstInViewport bool) int {
return 1
}),
)
// Test navigation on empty list (should not crash)