From 8f0644e35bd5757f1a8f7ce71481c8b6699901ba Mon Sep 17 00:00:00 2001
From: "Rico Sta. Cruz" <rstacruz@users.noreply.github.com>
Date: Thu, 24 Jul 2025 10:49:15 +1000
Subject: [PATCH] fix: update max visible height in list tests (#1269)

---
 .../tui/internal/components/list/list_test.go     | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/packages/tui/internal/components/list/list_test.go b/packages/tui/internal/components/list/list_test.go
index 4d954409..663503a4 100644
--- a/packages/tui/internal/components/list/list_test.go
+++ b/packages/tui/internal/components/list/list_test.go
@@ -34,7 +34,7 @@ func createTestList() *listComponent[testItem] {
 	}
 	list := NewListComponent(
 		WithItems(items),
-		WithMaxVisibleItems[testItem](5),
+		WithMaxVisibleHeight[testItem](5),
 		WithFallbackMessage[testItem]("empty"),
 		WithAlphaNumericKeys[testItem](false),
 		WithRenderFunc(
@@ -45,9 +45,6 @@ func createTestList() *listComponent[testItem] {
 		WithSelectableFunc(func(item testItem) bool {
 			return item.Selectable()
 		}),
-		WithHeightFunc(func(item testItem, isFirstInViewport bool) int {
-			return 1
-		}),
 	)
 
 	return list.(*listComponent[testItem])
@@ -84,7 +81,7 @@ func TestJKKeyNavigation(t *testing.T) {
 	// Create list with alpha keys enabled
 	list := NewListComponent(
 		WithItems(items),
-		WithMaxVisibleItems[testItem](5),
+		WithMaxVisibleHeight[testItem](5),
 		WithFallbackMessage[testItem]("empty"),
 		WithAlphaNumericKeys[testItem](true),
 		WithRenderFunc(
@@ -95,9 +92,6 @@ func TestJKKeyNavigation(t *testing.T) {
 		WithSelectableFunc(func(item testItem) bool {
 			return item.Selectable()
 		}),
-		WithHeightFunc(func(item testItem, isFirstInViewport bool) int {
-			return 1
-		}),
 	)
 
 	// Test j key (down)
@@ -176,7 +170,7 @@ func TestNavigationBoundaries(t *testing.T) {
 func TestEmptyList(t *testing.T) {
 	emptyList := NewListComponent(
 		WithItems([]testItem{}),
-		WithMaxVisibleItems[testItem](5),
+		WithMaxVisibleHeight[testItem](5),
 		WithFallbackMessage[testItem]("empty"),
 		WithAlphaNumericKeys[testItem](false),
 		WithRenderFunc(
@@ -187,9 +181,6 @@ func TestEmptyList(t *testing.T) {
 		WithSelectableFunc(func(item testItem) bool {
 			return item.Selectable()
 		}),
-		WithHeightFunc(func(item testItem, isFirstInViewport bool) int {
-			return 1
-		}),
 	)
 
 	// Test navigation on empty list (should not crash)