aljaz/nutshell
1
0
Fork 0
mirror of https://github.com/aljazceru/nutshell.git synced 2026-02-03 15:54:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix/fee_reserve_outputs (#261)

Browse Source 
* fix fee reserve

* fix tests
This commit is contained in:
callebtc
2023-06-23 20:47:56 +02:00
committed by GitHub
parent 5782421343
commit 339c3fb066
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cashu/core/helpers.py
View File

@@ -53,5 +53,5 @@ def calculate_number_of_blank_outputs(fee_reserve_sat: int):
"""
assert fee_reserve_sat >= 0, "Fee reserve can't be negative."
if fee_reserve_sat == 0:
return 1
return math.ceil(math.log2(fee_reserve_sat))
return 0
return max(math.ceil(math.log2(fee_reserve_sat)), 1)

9
tests/test_core.py
View File

@@ -43,8 +43,15 @@ def test_calculate_number_of_blank_outputs_for_small_fee_reserve():
assert n_blank_outputs == expected_n_blank_outputs
def test_calculate_number_of_blank_outputs_fails_for_negative_fee_reserve():
def test_calculate_number_of_blank_outputs_for_zero_fee_reserve():
# Negative fee reserve is not supported.
fee_reserve_sat = 0
n_blank_outputs = calculate_number_of_blank_outputs(fee_reserve_sat)
assert n_blank_outputs == 0
def test_calculate_number_of_blank_outputs_fails_for_negative_fee_reserve():
# Negative fee reserve is not supported.
fee_reserve_sat = -1
with pytest.raises(AssertionError):
_ = calculate_number_of_blank_outputs(fee_reserve_sat)