The response from the wide rendered note was incorrect, leading to and incorrectly sized hitbox. This fixes that. Additionally, we include note options and note parent into the hitbox key, as this may influence the size of the note. Before: https://cdn.jb55.com/s/b2464c22a65adb12.png After: https://cdn.jb55.com/s/52545564d98d278e.png Fixes: https://github.com/damus-io/notedeck/issues/519 Closes: https://github.com/damus-io/notedeck/pull/537 Changelog-Fixed: Fix broken quote repost hitbox Signed-off-by: William Casarin <jb55@jb55.com>
Damus Notedeck
A multiplatform nostr client. Works on android and desktop
The desktop client is called notedeck:
Android
Look it actually runs on android!
Usage
$ ./target/release/notedeck
Developer Setup
Desktop (Linux/MacOS, Windows?)
If you're running debian-based machine like Ubuntu or ElementaryOS, all you need is to install rustup and run sudo apt install build-essential.
$ cargo run --release
Android
The dev shell should also have all of the android-sdk dependencies needed for development, but you still need the aarch64-linux-android rustup target installed:
$ rustup target add aarch64-linux-android
To run on a real device, just type:
$ cargo apk run --release
Android Emulator
- Install Android Studio
- Open 'Device Manager' in Android Studio
- Add a new device with API level
34and ABIarm64-v8a(even though the app uses 30, the 30 emulator can't find the vulkan adapter, but 34 works fine) - Start up the emulator
while the emulator is running, run:
cargo apk run --release
The app should appear on the emulator
Previews
You can preview individual widgets and views by running the preview script:
./preview RelayView
./preview ProfilePreview
# ... etc
When adding new previews you need to implement the Preview trait for your
view/widget and then add it to the src/ui_preview/main.rs bin:
previews!(runner, name,
RelayView,
AccountLoginView,
ProfilePreview,
);
Contributing
Configure the developer environment:
./scripts/dev_setup.sh
This will add the pre-commit hook to your local repository to suggest proper formatting before commits.
