NoteActionResponse for note preview pfp clicking

Signed-off-by: kernelkind <kernelkind@gmail.com>

src/ui/note/contents.rs

@@ -1,4 +1,4 @@
-use crate::actionbar::BarAction;
+use crate::actionbar::NoteActionResponse;
 use crate::images::ImageType;
 use crate::imgcache::ImageCache;
 use crate::notecache::NoteCache;
@@ -17,7 +17,7 @@ pub struct NoteContents<'a> {
     note: &'a Note<'a>,
     note_key: NoteKey,
     options: NoteOptions,
-    action: Option<BarAction>,
+    action: NoteActionResponse,
 }
 
 impl<'a> NoteContents<'a> {
@@ -38,12 +38,12 @@ impl<'a> NoteContents<'a> {
             note,
             note_key,
             options,
-            action: None,
+            action: NoteActionResponse::default(),
         }
     }
 
-    pub fn action(&self) -> Option<BarAction> {
-        self.action
+    pub fn action(&self) -> &NoteActionResponse {
+        &self.action
     }
 }
 
@@ -211,7 +211,7 @@ fn render_note_contents(
     let note_action = if let Some((id, block_str)) = inline_note {
         render_note_preview(ui, ndb, note_cache, img_cache, txn, id, block_str).action
     } else {
-        None
+        NoteActionResponse::default()
     };
 
     if !images.is_empty() && !options.has_textmode() {

src/ui/note/mod.rs

@@ -13,7 +13,7 @@ pub use quote_repost::QuoteRepostView;
 pub use reply::PostReplyView;
 
 use crate::{
-    actionbar::BarAction,
+    actionbar::{BarAction, NoteActionResponse},
     app_style::NotedeckTextStyle,
     colors,
     imgcache::ImageCache,
@@ -22,7 +22,7 @@ use crate::{
 };
 use egui::emath::{pos2, Vec2};
 use egui::{Id, Label, Pos2, Rect, Response, RichText, Sense};
-use enostr::NoteId;
+use enostr::{NoteId, Pubkey};
 use nostrdb::{Ndb, Note, NoteKey, NoteReply, Transaction};
 
 use super::profile::preview::{get_display_name, one_line_display_name_widget};
@@ -37,37 +37,27 @@ pub struct NoteView<'a> {
 
 pub struct NoteResponse {
     pub response: egui::Response,
-    pub action: Option<BarAction>,
     pub context_selection: Option<NoteContextSelection>,
-    pub clicked_profile: bool,
+    pub action: NoteActionResponse,
 }
 
 impl NoteResponse {
     pub fn new(response: egui::Response) -> Self {
         Self {
             response,
-            action: None,
             context_selection: None,
-            clicked_profile: false,
+            action: NoteActionResponse::default(),
         }
     }
 
-    pub fn with_action(self, action: Option<BarAction>) -> Self {
-        Self { action, ..self }
+    pub fn with_action(mut self, action: NoteActionResponse) -> Self {
+        self.action = action;
+        self
     }
 
-    pub fn select_option(self, context_selection: Option<NoteContextSelection>) -> Self {
-        Self {
-            context_selection,
-            ..self
-        }
-    }
-
-    pub fn click_profile(self, clicked_profile: bool) -> Self {
-        Self {
-            clicked_profile,
-            ..self
-        }
+    pub fn select_option(mut self, context_selection: Option<NoteContextSelection>) -> Self {
+        self.context_selection = context_selection;
+        self
     }
 }
 
@@ -441,8 +431,11 @@ impl<'a> NoteView<'a> {
         puffin::profile_function!();
         let note_key = self.note.key().expect("todo: support non-db notes");
         let txn = self.note.txn().expect("todo: support non-db notes");
-        let mut note_action: Option<BarAction> = None;
+
+        let mut open_profile: Option<Pubkey> = None;
+        let mut bar_action: Option<BarAction> = None;
         let mut selected_option: Option<NoteContextSelection> = None;
+
         let profile = self.ndb.get_profile_by_pubkey(txn, self.note.pubkey());
         let maybe_hitbox = maybe_note_hitbox(ui, note_key);
         let container_right = {
@@ -452,12 +445,12 @@ impl<'a> NoteView<'a> {
             Pos2::new(x, y)
         };
 
-        let mut clicked_profile = false;
-
         // wide design
         let response = if self.options().has_wide() {
             ui.horizontal(|ui| {
-                clicked_profile = self.pfp(note_key, &profile, ui).clicked();
+                if self.pfp(note_key, &profile, ui).clicked() {
+                    open_profile = Some(Pubkey::new(*self.note.pubkey()));
+                };
 
                 let size = ui.available_size();
                 ui.vertical(|ui| {
@@ -500,18 +493,21 @@ impl<'a> NoteView<'a> {
                 self.options(),
             );
             let resp = ui.add(&mut contents);
-            note_action = note_action.or(contents.action());
+            bar_action = bar_action.or(contents.action().bar_action);
+            open_profile = open_profile.or(contents.action().open_profile);
 
             if self.options().has_actionbar() {
                 let ab = render_note_actionbar(ui, self.note.id(), note_key);
-                note_action = note_action.or(ab.inner);
+                bar_action = bar_action.or(ab.inner);
             }
 
             resp
         } else {
             // main design
             ui.with_layout(egui::Layout::left_to_right(egui::Align::TOP), |ui| {
-                clicked_profile = self.pfp(note_key, &profile, ui).clicked();
+                if self.pfp(note_key, &profile, ui).clicked() {
+                    open_profile = Some(Pubkey::new(*self.note.pubkey()));
+                };
 
                 ui.with_layout(egui::Layout::top_down(egui::Align::LEFT), |ui| {
                     selected_option = NoteView::note_header(
@@ -547,30 +543,33 @@ impl<'a> NoteView<'a> {
                         self.options(),
                     );
                     ui.add(&mut contents);
-                    note_action = note_action.or(contents.action());
+                    bar_action = bar_action.or(contents.action().bar_action);
+                    open_profile = open_profile.or(contents.action().open_profile);
 
                     if self.options().has_actionbar() {
                         let ab = render_note_actionbar(ui, self.note.id(), note_key);
-                        note_action = note_action.or(ab.inner);
+                        bar_action = bar_action.or(ab.inner);
                     }
                 });
             })
             .response
         };
 
-        note_action = check_note_hitbox(
+        bar_action = check_note_hitbox(
             ui,
             self.note.id(),
             note_key,
             &response,
             maybe_hitbox,
-            note_action,
+            bar_action,
         );
 
         NoteResponse::new(response)
-            .with_action(note_action)
+            .with_action(NoteActionResponse {
+                bar_action,
+                open_profile,
+            })
             .select_option(selected_option)
-            .click_profile(clicked_profile)
     }
 }
 

src/ui/timeline.rs

@@ -1,15 +1,13 @@
-use crate::actionbar::NoteActionResponse;
+use crate::actionbar::{BarAction, NoteActionResponse};
 use crate::timeline::TimelineTab;
 use crate::{
-    actionbar::BarAction, column::Columns, imgcache::ImageCache, notecache::NoteCache,
-    timeline::TimelineId, ui,
+    column::Columns, imgcache::ImageCache, notecache::NoteCache, timeline::TimelineId, ui,
 };
 use egui::containers::scroll_area::ScrollBarVisibility;
 use egui::{Direction, Layout};
 use egui_tabs::TabColor;
-use enostr::Pubkey;
 use nostrdb::{Ndb, Transaction};
-use tracing::{debug, error, info, warn};
+use tracing::{error, warn};
 
 pub struct TimelineView<'a> {
     timeline_id: TimelineId,
@@ -277,20 +275,12 @@ impl<'a> TimelineTabView<'a> {
                         .options_button(true)
                         .show(ui);
 
-                    if let Some(ba) = resp.action {
-                        bar_action = Some(ba);
-                    } else if resp.response.clicked() {
-                        debug!("clicked note");
-                    }
+                    bar_action = bar_action.or(resp.action.bar_action);
+                    open_profile = open_profile.or(resp.action.open_profile);
 
                     if let Some(context) = resp.context_selection {
                         context.process(ui, &note);
                     }
-
-                    if resp.clicked_profile {
-                        info!("clicked profile");
-                        open_profile = Some(Pubkey::new(*note.pubkey()))
-                    }
                 });
 
                 ui::hline(ui);