aljaz/lnd-manageJ
1
0
Fork 0
mirror of https://github.com/aljazceru/lnd-manageJ.git synced 2026-02-01 12:14:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

ignore channels with low remote balance as first hop

Browse Source
This commit is contained in:
Carsten Otto
2022-11-18 09:17:43 +01:00
parent 4674d3d99f
commit bb0ae0b300
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pickhardt-payments/src/main/java/de/cotto/lndmanagej/pickhardtpayments/EdgeComputation.java
View File

@@ -29,6 +29,7 @@ import java.util.function.Function;
@Component
public class EdgeComputation {
private static final Coins REMOTE_BALANCE_REQUIRED_TO_SEND = Coins.ofSatoshis(400);
private final Logger logger = LoggerFactory.getLogger(getClass());
private final GrpcGraph grpcGraph;
@@ -150,6 +151,10 @@ public class EdgeComputation {
Pubkey source = edge.startNode();
ChannelId channelId = edge.channelId();
if (ownPubKey.equals(source)) {
Coins availableRemote = getLocalChannelAvailableRemote(channelId).orElse(Coins.NONE);
if (availableRemote.subtract(REMOTE_BALANCE_REQUIRED_TO_SEND).isNonPositive()) {
return Optional.of(Coins.NONE);
}
return getLocalChannelAvailableLocal(channelId);
}
Pubkey target = edge.endNode();

17
pickhardt-payments/src/test/java/de/cotto/lndmanagej/pickhardtpayments/EdgeComputationTest.java
View File

@@ -4,6 +4,7 @@ import de.cotto.lndmanagej.grpc.GrpcGetInfo;
import de.cotto.lndmanagej.grpc.GrpcGraph;
import de.cotto.lndmanagej.grpc.middleware.GrpcMiddlewareService;
import de.cotto.lndmanagej.model.ChannelCoreInformation;
import de.cotto.lndmanagej.model.ChannelId;
import de.cotto.lndmanagej.model.Coins;
import de.cotto.lndmanagej.model.DirectedChannelEdge;
import de.cotto.lndmanagej.model.Edge;
@@ -198,11 +199,26 @@ class EdgeComputationTest {
Coins knownLiquidity = Coins.ofSatoshis(4_567);
Coins availableKnownLiquidity = getAvailableKnownLiquidity(knownLiquidity);
when(balanceService.getAvailableLocalBalance(EDGE.channelId())).thenReturn(knownLiquidity);
when(balanceService.getAvailableRemoteBalance(EDGE.channelId())).thenReturn(Coins.ofSatoshis(401));
assertThat(edgeComputation.getEdges(DEFAULT_PAYMENT_OPTIONS, MAX_TIME_LOCK_DELTA).edges())
.contains(EdgeWithLiquidityInformation.forKnownLiquidity(EDGE, availableKnownLiquidity));
}
@Test
void ignores_local_channels_with_lots_of_local_liquidity_but_almost_nothing_on_remote_side() {
// https://github.com/lightningnetwork/lnd/issues/7108
mockEdge();
ChannelId channelId = EDGE.channelId();
when(grpcGetInfo.getPubkey()).thenReturn(EDGE.startNode());
when(channelService.getOpenChannel(channelId)).thenReturn(Optional.of(LOCAL_OPEN_CHANNEL));
when(balanceService.getAvailableRemoteBalance(channelId)).thenReturn(Coins.ofSatoshis(400));
lenient().when(balanceService.getAvailableLocalBalance(channelId)).thenReturn(Coins.ofSatoshis(1_000_000));
assertThat(edgeComputation.getEdges(DEFAULT_PAYMENT_OPTIONS, MAX_TIME_LOCK_DELTA).edges())
.contains(EdgeWithLiquidityInformation.forKnownLiquidity(EDGE, Coins.NONE));
}
@Test
void adds_edge_from_route_hint_service() {
when(grpcGraph.getChannelEdges()).thenReturn(Optional.of(Set.of()));
@@ -307,6 +323,7 @@ class EdgeComputationTest {
Coins availableKnownLiquidity = getAvailableKnownLiquidity(knownLiquidity);
when(channelService.getOpenChannel(EDGE.channelId())).thenReturn(Optional.of(LOCAL_OPEN_CHANNEL));
when(balanceService.getAvailableLocalBalance(EDGE.channelId())).thenReturn(knownLiquidity);
when(balanceService.getAvailableRemoteBalance(EDGE.channelId())).thenReturn(Coins.ofSatoshis(401));
assertThat(edgeComputation.getEdgeWithLiquidityInformation(EDGE))
.isEqualTo(EdgeWithLiquidityInformation.forKnownLiquidity(EDGE, availableKnownLiquidity));
}