Rusty Russell e76a0b4ddc gossipd: fix race where we can handoff peer with bad cryptostate. ...

DEBUG:root:lightningd(16333): 2018-02-08T02:12:21.158Z lightningd(8262): lightning_openingd(0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199): Failed hdr decrypt with rn=2

We only hand off the peer if we've not started writing, but that was
insufficient: we increment the sn twice on encrypting packet, so there's
a window before we've actually started writing where this is now
wrong.

The simplest fix is only to hand off from master when we've just written,
and have the read-packet path simply wake the write-packet path.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2018-02-13 12:10:35 +01:00

..

test

wireaddr: rework port parsing for weird addresses.

2018-02-08 19:14:21 +01:00

bech32.c

bech32: move to common/

2017-11-24 13:22:18 +01:00

bech32.h

Fix typos

2017-12-08 13:07:20 +01:00

bip32.c

common: move some files out of lightningd/

2017-08-29 17:54:14 +02:00

bip32.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

bolt11.c

Avoid segfault on CLI command "decodepay 1111111" (invalid short bech32 string)

2018-01-15 19:32:00 +00:00

bolt11.h

Spelling corrections (#824)

2018-01-29 04:46:54 +00:00

channel_config.c

common: move some files out of lightningd/

2017-08-29 17:54:14 +02:00

channel_config.h

Revert "Send/receive cltv_expiry_delta in open/accept channel."

2017-10-11 11:54:50 +02:00

close_tx.c

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

close_tx.h

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

configdir.c

allow --rpc-file option to change default value

2018-02-02 20:35:44 +01:00

configdir.h

options: don't leak memory when people override options.

2017-12-13 22:46:10 +01:00

crypto_state.c

crypto_state: move to its own file.

2017-10-20 18:31:32 +02:00

crypto_state.h

crypto_state: move to its own file.

2017-10-20 18:31:32 +02:00

crypto_sync.c

common: add logging for peer packets, with status_io.

2018-02-07 00:46:49 +00:00

crypto_sync.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

cryptomsg.c

gossipd: fix race where we can handoff peer with bad cryptostate.

2018-02-13 12:10:35 +01:00

cryptomsg.h

gossipd: fix race where we can handoff peer with bad cryptostate.

2018-02-13 12:10:35 +01:00

daemon_conn.c

Spelling corrections (#824)

2018-01-29 04:46:54 +00:00

daemon_conn.h

daemon_conn: helper to release daemon_conn.

2017-12-17 02:44:20 +00:00

derive_basepoints.c

derive_basepoints: actually derive a separate HTLC key.

2017-11-16 17:40:57 +01:00

derive_basepoints.h

basepoints/secrets: add htlc entry

2017-11-16 17:40:57 +01:00

dev_disconnect.c

Spelling corrections (#824)

2018-01-29 04:46:54 +00:00

dev_disconnect.h

Add DEVELOPER flag, set by default.

2017-10-26 12:53:09 +02:00

features.c

features: Move feature-handling code to a common/features.c source.

2018-01-13 11:29:42 +01:00

features.h

features: Move feature-handling code to a common/features.c source.

2018-01-13 11:29:42 +01:00

funding_tx.c

common: remove unused assert() headers.

2017-10-26 12:53:09 +02:00

funding_tx.h

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

hash_u5.c

common/hash_u5: routines to hash 5 bit values.

2017-11-01 01:09:23 +00:00

hash_u5.h

common/hash_u5: routines to hash 5 bit values.

2017-11-01 01:09:23 +00:00

htlc_state.c

common: absorb remaining files from daemon/

2017-08-29 17:54:14 +02:00

htlc_state.h

Fix a-vs-an typos

2018-02-08 22:49:34 +01:00

htlc_tx.c

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

htlc_tx.h

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

htlc_wire.c

tools/generate_wire.py: make varlen structs self-allocate.

2018-02-08 19:07:12 +01:00

htlc_wire.h

tools/generate_wire.py: make varlen structs self-allocate.

2018-02-08 19:07:12 +01:00

htlc.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

initial_channel.c

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

initial_channel.h

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

initial_commit_tx.c

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

initial_commit_tx.h

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

io_debug.c

common/io_debug: replacement for ccan/io's poll which does sanity checks.

2017-09-29 10:20:08 +09:30

io_debug.h

common/io_debug: replacement for ccan/io's poll which does sanity checks.

2017-09-29 10:20:08 +09:30

json.c

common/json: Add json_add_double.

2018-02-09 12:44:33 +01:00

json.h

common/json: Add json_add_double.

2018-02-09 12:44:33 +01:00

key_derive.c

basepoints/secrets: add htlc entry

2017-11-16 17:40:57 +01:00

key_derive.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

keyset.c

typo

2017-11-23 23:10:08 +01:00

keyset.h

basepoints/secrets: add htlc entry

2017-11-16 17:40:57 +01:00

Makefile

status: generate messages rather than marshal/unmarshal manually.

2018-02-08 19:07:12 +01:00

memleak.c

Re-enable builds with DEVELOPER=0

2017-12-20 12:43:10 +01:00

memleak.h

Re-enable builds with DEVELOPER=0

2017-12-20 12:43:10 +01:00

msg_queue.c

common: move some files out of lightningd/

2017-08-29 17:54:14 +02:00

msg_queue.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

overflows.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

peer_failed.c

status: separate types for peer failure vs "impossible" failures.

2018-02-08 19:07:12 +01:00

peer_failed.h

status: use common status codes for all the failures.

2017-09-12 23:00:53 +02:00

permute_tx.c

permute_tx: bail on empty permute_{inputs/outputs} arguments

2018-01-15 06:35:02 +00:00

permute_tx.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

ping.c

common: move some files out of lightningd/

2017-08-29 17:54:14 +02:00

ping.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

pseudorand.c

common: absorb remaining files from daemon/

2017-08-29 17:54:14 +02:00

pseudorand.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

read_peer_msg.c

status: separate types for peer failure vs "impossible" failures.

2018-02-08 19:07:12 +01:00

read_peer_msg.h

status: separate types for peer failure vs "impossible" failures.

2018-02-08 19:07:12 +01:00

sphinx.c

Avoid writing uninitialized value data->realm in serialize_hop_data(...) (via create_onionpacket(...))

2017-12-28 16:09:46 +01:00

sphinx.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

status_levels.h

status: separate types for peer failure vs "impossible" failures.

2018-02-08 19:07:12 +01:00

status_wire.c

status: generate messages rather than marshal/unmarshal manually.

2018-02-08 19:07:12 +01:00

status_wire.csv

status: separate types for peer failure vs "impossible" failures.

2018-02-08 19:07:12 +01:00

status_wire.h

status: generate messages rather than marshal/unmarshal manually.

2018-02-08 19:07:12 +01:00

status.c

status: separate types for peer failure vs "impossible" failures.

2018-02-08 19:07:12 +01:00

status.h

status: separate types for peer failure vs "impossible" failures.

2018-02-08 19:07:12 +01:00

subdaemon.c

common: only log io if they set --debug-subdaemon-io=<daemon> or with SIGUSR1.

2018-02-07 00:46:49 +00:00

subdaemon.h

subdaemon.c: subdaemon_setup() routine for all daemons.

2018-01-08 18:16:39 +01:00

timeout.c

common: absorb remaining files from daemon/

2017-08-29 17:54:14 +02:00

timeout.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

type_to_string.c

type_to_string: support preimage.

2017-09-28 13:07:05 +09:30

type_to_string.h

bitcoin: create new wrapper type bitcoin_blkid, log backward endianness.

2017-12-21 11:05:38 +00:00

utils.c

tal_tmpctx: keep information around so we can find leaks.

2017-09-29 10:20:08 +09:30

utils.h

tal_tmpctx: keep information around so we can find leaks.

2017-09-29 10:20:08 +09:30

utxo.c

tools/generate_wire.py: generate varlen arrays properly.

2018-02-08 19:07:12 +01:00

utxo.h

tools/generate_wire.py: generate varlen arrays properly.

2018-02-08 19:07:12 +01:00

version.c

common: new directory for any shared objects.

2017-08-29 17:54:14 +02:00

version.h

Onboarding: Make log output texts friendlier to new users

2018-01-29 03:22:27 +00:00

wire_error.c

is_all_channels: rename to channel_id_is_all

2017-10-22 16:24:10 +02:00

wire_error.h

Spelling corrections (#824)

2018-01-29 04:46:54 +00:00

wireaddr.c

wireaddr: rework port parsing for weird addresses.

2018-02-08 19:14:21 +01:00

wireaddr.h

wireaddr: rework port parsing for weird addresses.

2018-02-08 19:14:21 +01:00

withdraw_tx.c

travis: reenable check-source (without BOLT text).

2017-12-21 14:33:27 +01:00

withdraw_tx.h

Change withdraw_tx to accept scriptpubkey rather than plain address.

2017-12-13 03:10:04 +00:00