aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-01-10 17:44:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

permute_tx: bail on empty permute_{inputs/outputs} arguments

Browse Source 
permute_outputs is sometimes called with empty arguments from initial_commit_tx.
Make sure we guard against that case. We also do the same in permute_inputs for
good measure.

Signed-off-by: William Casarin <jb55@jb55.com>
This commit is contained in:
William Casarin
2018-01-14 15:57:19 -08:00
committed by Rusty Russell
parent 4214c5ad57
commit 44f9863192
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
common/permute_tx.c
View File

@@ -59,6 +59,10 @@ void permute_inputs(struct bitcoin_tx_input *inputs, size_t num_inputs,
{
size_t i;
/* We can't permute nothing! */
if (num_inputs == 0)
return;
/* Now do a dumb sort (num_inputs is small). */
for (i = 0; i < num_inputs-1; i++) {
/* Swap best into first place. */
@@ -126,6 +130,10 @@ void permute_outputs(struct bitcoin_tx_output *outputs, size_t num_outputs,
{
size_t i;
/* We can't permute nothing! */
if (num_outputs == 0)
return;
/* Now do a dumb sort (num_outputs is small). */
for (i = 0; i < num_outputs-1; i++) {
/* Swap best into first place. */