Rusty Russell 2c3543e42d lightningd: fix crash when failing htlc once channeld dies. ...

We were reaching through it to get `ld`, but channeld is already dead.
Caught this on test_onchaind_replay (without valgrind) on my test machine:

    INFO 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-chan#1: Peer transient failure in CHANNELD_NORMAL: channeld: Owning subdaemon channeld died (62208)
    **BROKEN** lightningd: FATAL SIGNAL 11 (version f6e1735)
    **BROKEN** lightningd: backtrace: common/daemon.c:44 (send_backtrace) 0x5634dc83dc55
    **BROKEN** lightningd: backtrace: common/daemon.c:52 (crashdump) 0x5634dc83dca9
    **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7fd4b7c0b46f
    **BROKEN** lightningd: backtrace: lightningd/peer_htlcs.c:285 (failmsg_incorrect_or_unknown) 0x5634dc82625a
    **BROKEN** lightningd: backtrace: lightningd/htlc_set.c:109 (htlc_set_add) 0x5634dc801e5c
    **BROKEN** lightningd: backtrace: lightningd/peer_htlcs.c:496 (handle_localpay) 0x5634dc826997
    **BROKEN** lightningd: backtrace: lightningd/peer_htlcs.c:1008 (htlc_accepted_hook_callback) 0x5634dc827e60
    **BROKEN** lightningd: backtrace: lightningd/plugin_hook.c:197 (plugin_hook_callback) 0x5634dc831ea1
    **BROKEN** lightningd: backtrace: lightningd/plugin.c:261 (plugin_response_handle) 0x5634dc82d2c3
    **BROKEN** lightningd: backtrace: lightningd/plugin.c:359 (plugin_read_json_one) 0x5634dc82d46f
    **BROKEN** lightningd: backtrace: lightningd/plugin.c:391 (plugin_read_json) 0x5634dc82d5c6
    **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:59 (next_plan) 0x5634dc896319
    **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:407 (do_plan) 0x5634dc896efe
    **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:417 (io_ready) 0x5634dc896f40
   
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2020-04-16 09:39:49 +09:30

..

test

lightningd: fix crash when failing htlc once channeld dies.

2020-04-16 09:39:49 +09:30

.gitignore

handshaked: remove.

2017-10-20 18:31:32 +02:00

bitcoind.c

bcli: register --dev-max-fee-multiplier on our side

2020-03-30 20:17:18 +10:30

bitcoind.h

lightning/bitcoind: adapt and batch fees estimations

2020-03-30 20:17:18 +10:30

chaintopology.c

bcli: register --dev-max-fee-multiplier on our side

2020-03-30 20:17:18 +10:30

chaintopology.h

chaintopology: better feerate targets differentiation

2020-03-30 20:17:18 +10:30

channel_control.c

channeld: simplify loading of pre-existing HTLCs.

2020-04-04 16:08:49 +10:30

channel_control.h

channel control: break out separate method for canceling

2020-02-10 15:59:26 +10:30

channel_state.h

wallet: Add a final CLOSED state to channels

2019-06-30 16:41:30 +09:30

channel.c

closingd: configurable closing fee negotiation step

2020-04-07 13:52:48 +09:30

channel.h

closingd: configurable closing fee negotiation step

2020-04-07 13:52:48 +09:30

closing_control.c

closingd: configurable closing fee negotiation step

2020-04-07 13:52:48 +09:30

closing_control.h

common/per_per_state: generalize lightningd/peer_comm Part 1

2019-06-04 01:29:39 +00:00

connect_control.c

cleanup: make 'u8 *features' and 'struct feature_set *fset' more explicit.

2020-04-03 13:13:21 +10:30

connect_control.h

lightningd: return features in connect response.

2020-04-03 13:13:21 +10:30

gossip_control.c

lightningd: add blinding and enctlv field to struct route_hop.

2020-04-14 12:51:18 +09:30

gossip_control.h

gossipd: get fed the blockheight from lightningd when we know it.

2019-09-25 04:01:56 +00:00

gossip_msg.c

lightningd: add blinding and enctlv field to struct route_hop.

2020-04-14 12:51:18 +09:30

gossip_msg.h

lightningd: add blinding and enctlv field to struct route_hop.

2020-04-14 12:51:18 +09:30

hsm_control.c

common: generalize ecdh function.

2020-04-04 16:08:49 +10:30

hsm_control.h

Use node_id everywhere for nodes.

2019-04-09 12:37:16 -07:00

htlc_end.c

channeld: support HTLCs with blinding (EXPERIMENTAL_FEATURES)

2020-04-14 12:51:18 +09:30

htlc_end.h

channeld: support HTLCs with blinding (EXPERIMENTAL_FEATURES)

2020-04-14 12:51:18 +09:30

htlc_set.c

lightningd: fix crash when failing htlc once channeld dies.

2020-04-16 09:39:49 +09:30

htlc_set.h

lightningd: make local htlc failures pass a wiremsg for errors, not a failcode.

2020-02-25 11:12:12 +10:30

invoice.c

lightningd: fix crash when failing htlc once channeld dies.

2020-04-16 09:39:49 +09:30

invoice.h

lightningd: sew in htlc set.

2019-12-12 15:03:53 +01:00

io_loop_with_timers.c

plugins: don't crash if getmanifest times out.

2019-07-24 16:16:53 +02:00

io_loop_with_timers.h

lightningd/io_loop_with_timers.c: Move mainloop to its own source file, have chaintopology use it.

2019-05-31 17:57:10 +02:00

json.c

chaintopology: better feerate targets differentiation

2020-03-30 20:17:18 +10:30

json.h

common: move json_stream helpers to common/json

2020-02-04 13:24:32 +10:30

jsonrpc.c

plugin: Unwrap the rpc_command payload

2020-03-10 11:42:58 +10:30

jsonrpc.h

common: move json_stream from lightningd/ to common/

2020-02-04 13:24:32 +10:30

lightningd.c

features: add EXPERIMENTAL option_onion_messages from draft.

2020-04-14 12:51:18 +09:30

lightningd.h

cleanup: make 'u8 *features' and 'struct feature_set *fset' more explicit.

2020-04-03 13:13:21 +10:30

log_status.c

lightningd: kill per-peer daemons if they claim a different peer id.

2019-11-18 04:50:22 +00:00

log_status.h

lightningd: have logging include an optional node_id for each entry.

2019-11-18 04:50:22 +00:00

log.c

log: print UNUSUAL messages before log initialization too.

2019-11-23 22:42:34 +00:00

log.h

lightningd: use a simple array for less memory usage.

2019-11-18 04:50:22 +00:00

Makefile

channeld: support HTLCs with blinding (EXPERIMENTAL_FEATURES)

2020-04-14 12:51:18 +09:30

memdump.c

htlcs: Make sure htlc_sets is not erroneously flagged as a memleak

2019-12-12 22:16:03 +01:00

memdump.h

lightningd: add code to search strmaps for memleak detection.

2019-02-07 20:33:50 +00:00

notification.c

lightningd, openingd: remove active code inside assert().

2020-02-18 10:21:29 +10:30

notification.h

db: put scids in forwards even if we didn't actually send.

2020-02-12 22:27:57 -06:00

onchain_control.c

chaintopology: add delayed_to_us, htlc, and penalty feerates

2020-03-30 20:17:18 +10:30

onchain_control.h

onchaind: Replay stored channeltxs to restore onchaind state

2018-04-25 14:33:38 +02:00

onion_message.c

plugins: expose onion_message hook (EXPERIMENTAL_FEATURES)

2020-04-02 14:32:38 +10:30

onion_message.h

lightningd: forward onion messages.

2020-04-02 14:32:38 +10:30

opening_control.c

cleanup: make 'u8 *features' and 'struct feature_set *fset' more explicit.

2020-04-03 13:13:21 +10:30

opening_control.h

subd: Add a helper to get the current owning subd for a given peer

2020-01-28 23:50:52 +01:00

options.c

cleanup: make 'u8 *features' and 'struct feature_set *fset' more explicit.

2020-04-03 13:13:21 +10:30

options.h

common: parse --allow-deprecated-apis extremely early.

2019-11-23 22:42:34 +00:00

pay.c

lightningd: make sendpay support blinding and enctlv fields (EXPERIMENTAL)

2020-04-14 12:51:18 +09:30

pay.h

Use dedicated type for error codes

2020-01-31 06:02:47 +00:00

peer_control.c

lightningd: Don't accept 0sat for closing fee step

2020-04-07 12:45:34 -05:00

peer_control.h

cleanup: make 'u8 *features' and 'struct feature_set *fset' more explicit.

2020-04-03 13:13:21 +10:30

peer_htlcs.c

lightningd: fix crash when failing htlc once channeld dies.

2020-04-16 09:39:49 +09:30

peer_htlcs.h

lightningd: fix crash when failing htlc once channeld dies.

2020-04-16 09:39:49 +09:30

ping.c

bolt: update to BOLT spec changes (extract format + type specifications)

2019-07-16 06:10:58 +00:00

ping.h

ping: complete JSON RPC ping commands even if one ping gets no response.

2018-09-14 22:11:23 +02:00

plugin_control.c

plugin: Actually wait the 20 seconds promised in the docs

2020-02-27 09:21:44 +10:30

plugin_control.h

plugins: cleanup shared headers between dynamic and static plugins

2019-09-30 00:20:16 +00:00

plugin_hook.c

cleanup: Remove current_plugin from plugin_hook_request

2020-02-27 09:21:44 +10:30

plugin_hook.h

plugin: Multiple plugins can register a singl hook

2020-02-11 15:57:22 +10:30

plugin.c

plugin: Ensure RPC passthrough calls are terminated when plugin dies

2020-04-14 11:07:55 +09:30

plugin.h

plugin: Ensure RPC passthrough calls are terminated when plugin dies

2020-04-14 11:07:55 +09:30

signmessage.c

common/wireaddr: don't include lightningd/lightningd.

2020-02-27 14:16:16 +10:30

subd.c

lightningd: Added --subdaemon command to allow alternate subdaemons.

2020-02-04 10:44:13 +10:30

subd.h

lightningd: have optional node_id associated with subdaemons.

2019-11-18 04:50:22 +00:00

watch.c

wallet: remove edgecase around transaction checks

2020-01-02 16:56:42 +01:00

watch.h

lightningd: fix occasional missing txid detection.

2019-06-28 03:31:43 +00:00