aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-02-02 20:54:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

lightningd: Don't accept 0sat for closing fee step

Browse Source 
We must give up something on each negotiation step. Can't take 0 satoshi
as an argument.

Changelog-None
This commit is contained in:
Vasil Dimov
2020-04-07 11:49:07 +02:00
committed by neil saitug
parent 662ac26d0c
commit d2165ff4d8
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lightningd/peer_control.c
View File

@@ -1370,9 +1370,15 @@ static struct command_result *json_close(struct command *cmd,
} else {
channel->closing_fee_negotiation_step =
strtoull(fee_negotiation_step_str, &end, 10);
if (*end == '%') {
if (channel->closing_fee_negotiation_step < 1 ||
channel->closing_fee_negotiation_step > 100)
if (channel->closing_fee_negotiation_step == 0)
return command_fail(
cmd, JSONRPC2_INVALID_PARAMS,
"Wrong value given for fee_negotiation_step: "
"\"%s\", must be positive",
fee_negotiation_step_str);
else if (*end == '%') {
if (channel->closing_fee_negotiation_step > 100)
return command_fail(
cmd, JSONRPC2_INVALID_PARAMS,
"Wrong value given for "