aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 23:24:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

configure: suppress "maybe uninitialized" warnings altogether unless -O3.

Browse Source 
We were just telling GCC not to treat them as errors: this suppresses them
entirely unless at -O3.  People keep trying to "fix" them, when in fact
they're false positives, as revealed with "./configure COPTFLAGS=-O3".

Fixes: #2856
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2019-07-31 19:59:26 +09:30
committed by Christian Decker
parent 5a3ba1ce99
commit df298ba7e3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
configure vendored
View File

@@ -34,12 +34,12 @@ default_coptflags()
default_cwarnflags() default_cwarnflags()
{ {
F=$BASE_WARNFLAGS F=$BASE_WARNFLAGS
# Clang doesn't like -Wno-error=maybe-uninitialized, but doesn't seem # Clang doesn't like -Wno-maybe-uninitialized, but doesn't seem
# to give spurious warnings, either. # to give spurious warnings, either.
if [ "$2" = 1 ]; then if [ "$2" = 1 ]; then
# With old gccs, or optimization != -O3, we need to suppress some warnings. # With old gccs, or optimization != -O3, we need to suppress some warnings.
if [ -n "${1##*-O3*}" ] || [ "$3" != "1" ]; then if [ -n "${1##*-O3*}" ] || [ "$3" != "1" ]; then
F="$F -Wno-error=maybe-uninitialized" F="$F -Wno-maybe-uninitialized"
fi fi
fi fi
echo "$F" echo "$F"