From df298ba7e35fbb9ba4f8cfeb016cbf57b80738ba Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Wed, 31 Jul 2019 19:59:26 +0930 Subject: [PATCH] configure: suppress "maybe uninitialized" warnings altogether unless -O3. We were just telling GCC not to treat them as errors: this suppresses them entirely unless at -O3. People keep trying to "fix" them, when in fact they're false positives, as revealed with "./configure COPTFLAGS=-O3". Fixes: #2856 Signed-off-by: Rusty Russell --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 3ebebb2c8..7920f6f5f 100755 --- a/configure +++ b/configure @@ -34,12 +34,12 @@ default_coptflags() default_cwarnflags() { F=$BASE_WARNFLAGS - # Clang doesn't like -Wno-error=maybe-uninitialized, but doesn't seem + # Clang doesn't like -Wno-maybe-uninitialized, but doesn't seem # to give spurious warnings, either. if [ "$2" = 1 ]; then # With old gccs, or optimization != -O3, we need to suppress some warnings. if [ -n "${1##*-O3*}" ] || [ "$3" != "1" ]; then - F="$F -Wno-error=maybe-uninitialized" + F="$F -Wno-maybe-uninitialized" fi fi echo "$F"