aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-20 23:54:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

pytest: fix tests/test_cln_rs.py to avoid race.

Browse Source 
When we release too fast, the plugin crashes:

```
thread 'tokio-runtime-worker' panicked at 'called Result::unwrap() on an Err value: SendError(())', plugins/examples/cln-plugin-reentrant.rs:31:27
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
```

This happens with CI under VALGRIND!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-05-18 15:44:01 +09:30
committed by Christian Decker
parent d1cf88c62e
commit b746588356
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/test_cln_rs.py
View File

@@ -4,7 +4,7 @@ from pathlib import Path
from pyln.testing import node_pb2 as nodepb
from pyln.testing import node_pb2_grpc as nodegrpc
from pyln.testing import primitives_pb2 as primitivespb
from pyln.testing.utils import env, TEST_NETWORK, wait_for, sync_blockheight
from pyln.testing.utils import env, TEST_NETWORK, wait_for, sync_blockheight, TIMEOUT
import grpc
import pytest
import subprocess
@@ -275,14 +275,13 @@ def test_cln_plugin_reentrant(node_factory, executor):
f1 = executor.submit(l2.rpc.pay, i1)
f2 = executor.submit(l2.rpc.pay, i2)
import time
time.sleep(3)
l1.daemon.wait_for_logs(["plugin-cln-plugin-reentrant: Holding on to incoming HTLC Object"] * 2)
print("Releasing HTLCs after holding them")
l1.rpc.call('release')
assert f1.result()
assert f2.result()
assert f1.result(timeout=TIMEOUT)
assert f2.result(timeout=TIMEOUT)
def test_grpc_keysend_routehint(bitcoind, node_factory):