aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-02-11 17:14:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

peer_control: Fix check_funding_details assert

Browse Source 
Check funding_outnum validity first to avoid reading invalid outputs

Changelog-Fixed: Fixed a potential issue if the number of outputs decreases in a dualopen RBF or splice.
This commit is contained in:
Dustin Dettmer
2022-07-05 15:44:38 -05:00
committed by neil saitug
parent 0a4cd91028
commit 9296537edb
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lightningd/peer_control.c
View File

@@ -1437,15 +1437,16 @@ static bool check_funding_details(const struct bitcoin_tx *tx,
struct amount_sat funding,
u32 funding_outnum)
{
struct amount_asset asset =
bitcoin_tx_output_get_amount(tx, funding_outnum);
if (!amount_asset_is_main(&asset))
return false;
struct amount_asset asset;
if (funding_outnum >= tx->wtx->num_outputs)
return false;
asset = bitcoin_tx_output_get_amount(tx, funding_outnum);
if (!amount_asset_is_main(&asset))
return false;
if (!amount_sat_eq(amount_asset_to_sat(&asset), funding))
return false;