aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

gossipstore: fix uninitialized input fd

Browse Source 
Initialize infd to STDIN_FILENO if the input file argument is missing.

Caught with gcc version: 7.4.0

devtools/create-gossipstore.c: In function ‘main’:
devtools/create-gossipstore.c:130:9: error: ‘infd’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
  while (read_all(infd, &be_inlen, sizeof(be_inlen))) {

Suggested-by: @ZmnSCPxj <https://github.com/ElementsProject/lightning/pull/2674#issuecomment-495617253>
Signed-off-by: William Casarin <jb55@jb55.com>
This commit is contained in:
William Casarin
2019-05-24 02:57:30 -07:00
committed by Rusty Russell
parent 3f035cb3cc
commit 6f635b46fd
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
devtools/create-gossipstore.c
View File

@@ -115,6 +115,8 @@ int main(int argc, char *argv[])
if (infd < 0) if (infd < 0)
err(1, "opening %s", infile); err(1, "opening %s", infile);
} }
else
infd = STDIN_FILENO;
if (outfile) { if (outfile) {
outfd = open(outfile, O_WRONLY|O_TRUNC|O_CREAT, 0666); outfd = open(outfile, O_WRONLY|O_TRUNC|O_CREAT, 0666);